Skip to content

fix: thermo-nuclear follow-ups for 0.43.0 ports#208

Merged
Finesssee merged 1 commit into
mainfrom
fix/thermo-043-followups
Jul 17, 2026
Merged

fix: thermo-nuclear follow-ups for 0.43.0 ports#208
Finesssee merged 1 commit into
mainfrom
fix/thermo-043-followups

Conversation

@Finesssee

Copy link
Copy Markdown
Collaborator

Summary

Closes thermo-nuclear FOLLOW_UP findings from merged 0.43.0 port PRs #202#207 (skip #205 Blacksmith).

P0 / correctness

P1

P2 / hygiene

  • Document that CostScanOptions is not wired into production CostScanner yet (disk-cache path).
  • sub2api settings env label is SUB2API_API_KEY only.

Deferred (not in this PR)

  • Factory megafile split (models / credentials / http)
  • Full disk-cache wiring for CostScanOptions in CostScanner
  • Identity flicker migration (token ↔ email) beyond dropping plan fallback

Test plan

  • cargo test --manifest-path rust/Cargo.toml --lib -- factory sub2api interleaved_lineage cost_scan_options kimi claude::web_api
  • cargo test --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml -- informational_primary quota_notification
  • Manual: toggle provider enablement mid-refresh → follow-up refresh starts
  • Manual: Factory cookie-source off + API key → no browser scrape
  • Manual: Claude web null five_hour + Session metric → no phantom 0% tray bar

Close P0/P1 findings from reviews of PRs #202-#207: refresh generation lock ownership, Factory cookie-off/dotenv/usage, sub2api Kind mapping, notification identity, informational tray metrics, and watermark containment.
@Finesssee
Finesssee merged commit 08cf6f7 into main Jul 17, 2026
1 check was pending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant