fix: thermo-nuclear follow-ups for 0.43.0 ports#208
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes thermo-nuclear FOLLOW_UP findings from merged 0.43.0 port PRs #202–#207 (skip #205 Blacksmith).
P0 / correctness
invalidate_provider_refresh_and_prune_disabledclearsis_refreshing; supersededfinish_provider_refreshreturnsNoneand skips tray /refresh-complete/ enrichment.SourceMode::Cliis API-only (no browser scrape). Empty dotenv no longer short-circuits a later key. Empty nestedusage: {}falls through to top-level windows. Resolve API key once per Auto fetch.P1
Kinddrives snapshot construction (limit-less subscription shows usage, not empty quota; balance surfaces with subscription). Plan goes tologin_methodonly (not organization).supports_opus: false. Mode attached to login when meaningful.plan:ownership fallback.X-Msh-Device-Idwhen CLI file missing (no per-fetch UUID churn).P2 / hygiene
CostScanOptionsis not wired into productionCostScanneryet (disk-cache path).SUB2API_API_KEYonly.Deferred (not in this PR)
models/credentials/http)CostScanOptionsinCostScannerTest plan
cargo test --manifest-path rust/Cargo.toml --lib -- factory sub2api interleaved_lineage cost_scan_options kimi claude::web_apicargo test --manifest-path apps/desktop-tauri/src-tauri/Cargo.toml -- informational_primary quota_notification