Skip to content

fix: allow single-label domains as network resources #670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Squiddim wants to merge 1 commit into
base: main
Choose a base branch
from
+2 −6
Open

fix: allow single-label domains as network resources #670

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions src/modules/networks/resources/ResourceSingleAddressInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,8 @@ export const ResourceSingleAddressInput = ({

// Case 1: If it has characters (potential domain) but is not a CIDR block
if (hasChars && !isCIDRBlock) {
if (
!validator.isValidDomain(value) ||
!value.includes(".") ||
value.endsWith(".")
) {
return "Please enter a valid domain, e.g. service.internal, example.com or *.example.com";
if (!validator.isValidDomain(value) || value.endsWith(".")) {
return "Please enter a valid domain, e.g. service.internal, example.com, *.example.com or service";
}
Comment thread
Squiddim marked this conversation as resolved.
return ""; // Valid domain
}
Expand Down