Skip to content

Fix update instructions for Synology NAS - #959

Merged
TechHutTV merged 1 commit into
netbirdio:mainfrom
martinyelland:patch-1
Sep 1, 2026
Merged

Fix update instructions for Synology NAS#959
TechHutTV merged 1 commit into
netbirdio:mainfrom
martinyelland:patch-1

Conversation

@martinyelland

@martinyelland martinyelland commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Updated instructions for updating Netbird on Synology NAS. Existing instructions executed as-is assume the user is root (with permission to chmod).

  • Aligned with the uninstall instructions by first stepping the user into a root shell.
  • cd the tmp folder

Summary by CodeRabbit

  • Documentation
    • Updated Synology upgrade instructions with explicit steps for connecting via SSH, switching to root access, stopping NetBird, and running the upgrade from /tmp.

Added instructions for updating Netbird on Synology NAS.
@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

@martinyelland is attempting to deploy a commit to the NetBird GmbH Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 28001220-22df-4ecf-aaf4-85c694049e2f

📥 Commits

Reviewing files that changed from the base of the PR and between c079d78 and 954885f.

📒 Files selected for processing (1)
  • src/pages/get-started/install/synology.mdx

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The Synology update instructions now include SSH access, root access with sudo -i, and execution of the upgrade script from /tmp after stopping NetBird.

Changes

Synology update procedure

Layer / File(s) Summary
Update procedure instructions
src/pages/get-started/install/synology.mdx
The procedure adds SSH and root-user steps, labels the upgrade-script step, and changes to /tmp after stopping NetBird.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: 🔵 Low · up to 95488

The update guide now runs downloaded code as root from the predictable /tmp/install.sh path. If another local user can influence that file, the NAS could execute attacker-controlled code with root privileges, so merge should proceed only with explicit owner awareness or follow-up to use a private temporary directory and confirm the supported DSM permissions.

Suggested reviewers: sunsetdrifter

Poem

A rabbit hops through /tmp with care
SSH commands neatly laid bare
Root steps follow, clear and bright
NetBird rests before the flight
The upgrade script runs just right

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the Synology NAS update-instruction changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/pages/get-started/install/synology.mdx

typescript-eslint does not support TS 7.0.
Please see https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0 to run typescript-eslint using the TS 6 API.
See also typescript-eslint/typescript-eslint#10940 for tracking typescript-eslint's support for TS >=7.1

Oops! Something went wrong! :(

ESLint: 9.39.5

Error: typescript-eslint does not support TS 7.0.
at Object. (/.eslint-tmp/node_modules/typescript-eslint/dist/index.js:52:11)
at Module._compile (node:internal/modules/cjs/loader:1830:14)
at Object..js (node:internal/modules/cjs/loader:1961:10)
at Module.load (node:internal/modules/cjs/loader:1553:32)
at Module._load (node:internal/modules/cjs/loader:1355:12)
at wrapModuleLoad (node:internal/modules/cjs/loader:255:19)
at Module.require (node:internal/modules/cjs/loader:1576:12)
at require (node:internal/modules/helpers:153:16)
at Object. (/.eslint-tmp/node_modules/eslint-config-next/dist/index.js:5:64)
at Module._compile (node:internal/modules/cjs/loader:1830:14)


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 1, 2026 11:39pm UTC

Request Review

@TechHutTV
TechHutTV merged commit b5ef5c2 into netbirdio:main Sep 1, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants