Fix update instructions for Synology NAS - #959
Conversation
Added instructions for updating Netbird on Synology NAS.
|
@martinyelland is attempting to deploy a commit to the NetBird GmbH Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe Synology update instructions now include SSH access, root access with ChangesSynology update procedure
Estimated code review effort: 1 (Trivial) | ~3 minutes Merge Risk: 🔵 Low · up to The update guide now runs downloaded code as root from the predictable /tmp/install.sh path. If another local user can influence that file, the NAS could execute attacker-controlled code with root privileges, so merge should proceed only with explicit owner awareness or follow-up to use a private temporary directory and confirm the supported DSM permissions. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Warning Some tools did not complete. Review the errors below. 🔧 ESLint
src/pages/get-started/install/synology.mdxtypescript-eslint does not support TS 7.0. Oops! Something went wrong! :( ESLint: 9.39.5 Error: typescript-eslint does not support TS 7.0. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Updated instructions for updating Netbird on Synology NAS. Existing instructions executed as-is assume the user is root (with permission to chmod).
cdthe tmp folderSummary by CodeRabbit
/tmp.