Repository navigation
fix: preserve instance selections missing from response metadata - #239
Merged
Merged
Conversation
ktsaou
marked this pull request as ready for review
September 29, 2026 10:11
novykh
approved these changes
Sep 29, 2026
novykh
pushed a commit
that referenced
this pull request
Sep 29, 2026
novykh
added a commit
that referenced
this pull request
Sep 29, 2026
* Drop touch gestures that gain a finger the chart never saw dygraphs records the touches of touchstart and, on a two-finger touchmove, reads initialTouches[1]. When the second finger lands outside the chart its touchstart never reaches the canvas, yet later touchmove events list both fingers, so moveTouch read initialTouches[1].pageX of undefined. touchMove now clears the stale gesture and ignores the event when it carries more touches than the gesture started with. * fix: preserve instance selections missing from response metadata (#239) * v6.12.16 --------- Co-authored-by: Costa Tsaousis <costa@tsaousis.gr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Preserve each valid instance selector when it has no match in a response's instance summary. Continue resolving matching IDs, names and patterns and deduplicating them as before.
Previously an empty or incomplete summary removed unmatched selections. If every selection disappeared, the next data request used
instances: ["*"], silently broadening a chart intended for a specific instance/node. A partial summary also permanently lost missing members of a multi-selection.Scope
One normalization fallback and focused regression tests. No changes to chart rendering, caching, routing or anomaly scoring. This fixes the independently reproduced selector loss; it does not claim to establish the cause of every delayed chart render.
Validation
git diff --check.