fix: fall back to linking the changelog when it is too long for the release - #124
Merged
Merged
Conversation
…elease v35.0.0 failed the changelog step: HTTP 422: Validation Failed https://api.github.com/repos/nextcloud-releases/server/releases/389498347 GitHub caps a release body at 125,000 characters and the generated changelog came to 308,810 bytes, so writing it as release notes was rejected. Over the limit, the body now points at the attached files instead: ## Nextcloud 35.0.0 The changelog is too long to show here. You can find it in the assets below: - **[Read it in your browser](.../changelog-v35.0.0.html)** - **[Download it as text](.../changelog-v35.0.0.md)** Attaching the files now happens before the notes are written, so those links point at something that already exists. It also fixes a second problem with the same failure: the upload step ran after the body was set, so when the body was rejected the job died and the changelog files were never attached at all. Both were lost on that run, and the ones on the release today were put there by hand. The threshold is 120,000 bytes rather than 125,000 characters. Bytes are never fewer than characters, so a changelog with non-ASCII names trips the fallback slightly early, which is the harmless direction. Assisted-by: ClaudeCode:claude-opus-5 Signed-off-by: skjnldsv <skjnldsv@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The changelog step failed on v35.0.0 (run 35026961957):
GitHub caps a release body at 125,000 characters, and the generated changelog came to 308,810 bytes. Over the limit, the body now points at the attached files instead:
There was a second problem behind the same failure, which is why the step order changed.
Attach changelog files to releaseran after the body was written, so when the body was rejected the job died and the files were never attached either. Both were lost on that run, and what is on the release today was put there by hand. Attaching now happens first, which also means the fallback links point at something that already exists.The threshold is 120,000 bytes rather than 125,000 characters. Bytes are never fewer than characters, so a changelog full of non-ASCII names trips the fallback slightly early, which is the harmless direction to be wrong in.
Tested the shell locally on both paths: a small changelog passes through unchanged, an oversized one produces exactly the body above, and the boundary behaves (120,000 bytes uses the changelog, 120,001 falls back). Both asset URLs return 200 against the real v35.0.0 release, so the link shape is right.
The workflow itself has not run with this change. The next major release is the real test; a re-dispatch of
Generate release changelogforv35.0.0would exercise the fallback path immediately if you want it proven before then.👾 This pull request was assisted by Claude Code, commits carry an
Assisted-bytrailer.