Skip to content

Add primary ripple for full screen exoplayer controls #17054

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndyScherzinger wants to merge 4 commits into
base: master
Choose a base branch
from
+8 −1
Open

Add primary ripple for full screen exoplayer controls #17054

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6026fa4
style: Add primary ripple for full screen exoplayer controls
AndyScherzinger May 15, 2026
6ecebac
style: Add primary ripple for full screen exoplayer controls
AndyScherzinger May 15, 2026
2a66a5f
fix ripple also for video fragment
tobiasKaminsky May 15, 2026
02a542d
Merge remote-tracking branch 'origin/style/noid/exoPlayerControllsRip…
tobiasKaminsky May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion app/src/main/java/com/owncloud/android/ui/preview/PreviewVideoFullscreenDialog.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ import androidx.media3.ui.PlayerView
import com.nextcloud.client.media.ExoplayerListener
import com.nextcloud.client.media.NextcloudExoPlayer
import com.nextcloud.common.NextcloudClient
import com.owncloud.android.R
import com.owncloud.android.databinding.DialogPreviewVideoBinding
import com.owncloud.android.lib.common.utils.Log_OC

Expand All @@ -40,7 +41,7 @@ class PreviewVideoFullscreenDialog(
nextcloudClient: NextcloudClient,
private val sourceExoPlayer: ExoPlayer,
private val sourceView: PlayerView
) : Dialog(sourceView.context, android.R.style.Theme_Black_NoTitleBar_Fullscreen) {
) : Dialog(sourceView.context, R.style.Dialog_FullscreenVideo) {

private val binding: DialogPreviewVideoBinding = DialogPreviewVideoBinding.inflate(layoutInflater)
private var playingStateListener: androidx.media3.common.Player.Listener? = null
Expand Down
6 changes: 6 additions & 0 deletions app/src/main/res/values/styles.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,6 +247,7 @@

<style name="Theme.ownCloud.Media" parent="Theme.Material3.DayNight.NoActionBar">
<item name="android:windowLayoutInDisplayCutoutMode">shortEdges</item>
<item name="android:colorControlHighlight">@color/primary</item>
</style>

<style name="ToolbarStyle.Overflow" parent="@style/Widget.AppCompat.ActionButton.Overflow">
Expand Down Expand Up @@ -491,4 +492,9 @@
<item name="postSplashScreenTheme">@style/Theme.ownCloud.Launcher</item>
</style>


<style name="Dialog.FullscreenVideo" parent="android:Theme.Material.NoActionBar.Fullscreen">
<item name="android:windowBackground">@android:color/black</item>
<item name="android:colorControlHighlight">@color/primary</item>
</style>
</resources>
Loading