Skip to content

[stable32] Avoid occ circles:check from failing because of outdated cache values #2570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
salmart-dev merged 1 commit into from
Jul 3, 2026
Merged

[stable32] Avoid occ circles:check from failing because of outdated cache values #2570

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions lib/Command/CirclesCheck.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

use Exception;
use OC\Core\Command\Base;
use OC\Memcache\APCu;
use OCA\Circles\AppInfo\Application;
use OCA\Circles\AppInfo\Capabilities;
use OCA\Circles\Exceptions\FederatedEventException;
Expand Down Expand Up @@ -39,6 +40,7 @@
use OCA\Circles\Tools\Traits\TNCRequest;
use OCA\Circles\Tools\Traits\TStringTools;
use OCP\IAppConfig;
use OCP\IConfig;
use Symfony\Component\Console\Helper\QuestionHelper;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
Expand Down Expand Up @@ -67,6 +69,7 @@ class CirclesCheck extends Base {
public function __construct(
private Capabilities $capabilities,
private IAppConfig $appConfig,
private IConfig $config,
private InterfaceService $interfaceService,
private FederatedEventService $federatedEventService,
private RemoteService $remoteService,
Expand Down Expand Up @@ -262,6 +265,17 @@ private function testLoopback(InputInterface $input, OutputInterface $output): b
return false;
}

$localIsApcu = ltrim($this->config->getSystemValueString('memcache.local'), '\\') === '\OC\Memcache\APCu';
if ($localIsApcu) {
/*
* APCu cache is not shared between the CLI process and web requests, so freshly
* set values will either be missing or stale and make the check fail.
* The amount of seconds slept here depends on the TTL set by the AppConfig.
*/
$output->writeln('- Waiting for APCu config cache to refresh (4s)');
sleep(4);
}

if (!$this->testRequest(
$output, 'POST', 'circles.EventWrapper.asyncBroadcast',
['token' => 'test-dummy-token']
Expand Down
Loading