chore(lint): fix eslint warnings

src/components/AppContent/CircleContent.vue

@@ -54,7 +54,7 @@ export default {
 	props: {
 		loading: {
 			type: Boolean,
-			default: true,
+			required: true,
 		},
 	},
 

src/components/AppContent/ContactsContent.vue

@@ -52,7 +52,7 @@
 		</template>
 
 		<!-- main contacts details -->
-		<ContactDetails :contact-key="selectedContact" :contacts="sortedContacts" :reload-bus="reloadBus" />
+		<ContactDetails :contact-key="selectedContact" :reload-bus="reloadBus" />
 	</AppContent>
 </template>
 
@@ -88,7 +88,7 @@ export default {
 	props: {
 		loading: {
 			type: Boolean,
-			default: true,
+			required: true,
 		},
 
 		contactsList: {
@@ -97,6 +97,8 @@ export default {
 		},
 	},
 
+	emits: ['new-contact'],
+
 	data() {
 		return {
 			searchQuery: '',

src/components/AppNavigation/ContactsSettings.vue

@@ -74,6 +74,8 @@ export default {
 		},
 	},
 
+	emits: ['update:open', 'clicked', 'file-loaded'],
+
 	data() {
 		return {
 			allowSocialSync: loadState('contacts', 'allowSocialSync') !== 'no',

src/components/AppNavigation/GroupNavigationItem.vue

@@ -130,6 +130,8 @@ export default {
 		},
 	},
 
+	emits: ['updateRouteState'],
+
 	data() {
 		return {
 			newGroupName: '',
@@ -249,7 +251,7 @@ export default {
 		 * Open mailto: for contacts in a group
 		 *
 		 * @param {object} group of contacts to be emailed
-		 * @param {string} mode
+		 * @param {string} mode the recipient header to use (to, cc, bcc)
 		 */
 		emailGroup(group, mode = 'to') {
 			const emails = []

src/components/AppNavigation/Settings/SettingsImportContacts.vue

@@ -14,7 +14,6 @@
 			</NcButton>
 			<Modal
 				v-if="isOpened"
-				ref="modal"
 				class="import-contact__modal"
 				:name="t('contacts', 'Import contacts')"
 				@close="toggleModal">

src/components/ChartTemplate.vue

@@ -56,11 +56,6 @@ export default {
 			type: Object,
 			default: () => {},
 		},
-
-		onAvatarClick: {
-			type: Function,
-			default: () => {},
-		},
 	},
 
 	computed: {

src/components/CircleDetails.vue

@@ -680,10 +680,10 @@ export default {
 		},
 
 		/**
-		 * Autocomplete @mentions on the description
+		 * Autocomplete `@mentions` on the description
 		 *
 		 * @param {string} search the search term
-		 * @param {Function} callback callback to be called with results array
+		 * @param {(results: object[]) => void} callback callback to be called with results array
 		 */
 		onAutocomplete(search, callback) {
 			// TODO: implement autocompletion. Disabled for now

src/components/ConfirmationDialog.vue

@@ -57,7 +57,7 @@ export default {
 
 		disabled: {
 			type: Boolean,
-			default: undefined,
+			default: false,
 		},
 	},
 

src/components/ContactDetails.vue

@@ -51,6 +51,7 @@
 				<!-- org, title -->
 				<template #subtitle>
 					<template v-if="isReadOnly">
+						<!-- eslint-disable-next-line vue/no-v-html -- title and organization are escaped in formattedSubtitle -->
 						<span v-html="formattedSubtitle" />
 					</template>
 					<template v-else>
@@ -100,13 +101,13 @@
 								<IconMail :size="20" />
 							</template>
 							<ActionLink
-								v-for="emailAddress in emailAddressList"
-								:key="emailAddress"
-								:href="'mailto:' + emailAddress">
+								v-for="address in emailAddressList"
+								:key="address"
+								:href="'mailto:' + address">
 								<template #icon>
 									<IconMail :size="20" />
 								</template>
-								{{ emailAddress }}
+								{{ address }}
 							</ActionLink>
 						</Actions>
 						<Actions
@@ -200,7 +201,6 @@
 					<!-- user can clone if there is at least one option available -->
 					<ActionButton
 						v-if="isReadOnly && addressbooksOptions.length > 0"
-						ref="cloneAction"
 						:close-after-click="true"
 						@click="cloneContact">
 						<template #icon>
@@ -258,7 +258,6 @@
 				:name="t('contacts', 'Pick an address book')"
 				@close="closePickAddressbookModal">
 				<NcSelect
-					ref="pickAddressbook"
 					v-model="pickedAddressbook"
 					class="address-book"
 					:allow-empty="false"
@@ -293,7 +292,6 @@
 							:property="property"
 							:contact="contact"
 							:local-contact="localContact"
-							:contacts="contacts"
 							:bus="bus"
 							:is-read-only="isReadOnly" />
 					</div>
@@ -319,7 +317,6 @@
 				<PropertyGroups
 					:value="localContact.groups"
 					:prop-model="groupsModel"
-					:contact="contact"
 					:is-read-only="isReadOnly"
 					class="property--groups property--last"
 					@update:value="updateGroups" />
@@ -496,11 +493,6 @@ export default defineComponent({
 			default: undefined,
 		},
 
-		contacts: {
-			type: Array,
-			default: () => [],
-		},
-
 		reloadBus: {
 			type: Object,
 			required: true,

src/components/ContactDetails/ContactDetailsAvatar.vue

@@ -173,6 +173,8 @@ export default {
 		},
 	},
 
+	emits: ['update-local-contact'],
+
 	data() {
 		return {
 			opened: false,

src/components/ContactDetails/ContactDetailsProperty.vue

@@ -78,11 +78,6 @@ export default {
 			default: null,
 		},
 
-		contacts: {
-			type: Array,
-			default: () => [],
-		},
-
 		bus: {
 			type: Object,
 			required: true,

src/components/ContactsList/Merging.vue

@@ -193,6 +193,8 @@ export default {
 		},
 	},
 
+	emits: ['finished'],
+
 	data() {
 		return {
 			bus: mitt(),

src/components/DetailsHeader.vue

@@ -31,7 +31,6 @@
 
 			<!-- menu actions -->
 			<Actions
-				ref="actions"
 				class="header-menu"
 				menu-align="right"
 				v-bind="$attrs">

src/components/EntityPicker/EntityBubble.vue

@@ -72,6 +72,8 @@ export default {
 		},
 	},
 
+	emits: ['delete'],
+
 	setup() {
 		return {
 			ShareType,

src/components/EntityPicker/EntityPicker.vue

@@ -175,14 +175,6 @@ export default {
 			},
 		},
 
-		/**
-		 * The sorting key for the dataSet
-		 */
-		sort: {
-			type: String,
-			default: 'label',
-		},
-
 		/**
 		 * Confirm button text
 		 */
@@ -205,7 +197,7 @@ export default {
 		 */
 		internalSearch: {
 			type: Boolean,
-			default: true,
+			default: true, // eslint-disable-line vue/no-boolean-default -- default is true for backward compatibility with existing callers
 		},
 
 		/**
@@ -223,6 +215,8 @@ export default {
 		},
 	},
 
+	emits: ['update:selection', 'close', 'submit', 'search'],
+
 	data() {
 		return {
 			canInviteGuests: !!window?.OCA?.Guests?.openGuestDialog,

src/components/EntityPicker/NewCircleIntro.vue

@@ -90,6 +90,8 @@ export default {
 		},
 	},
 
+	emits: ['close', 'submit'],
+
 	data() {
 		return {
 			circleName: '',

src/components/MemberList/MemberList.vue

@@ -62,7 +62,7 @@
 import { showError, showWarning } from '@nextcloud/dialogs'
 import { subscribe } from '@nextcloud/event-bus'
 import { t } from '@nextcloud/l10n'
-import { NcEmptyContent } from '@nextcloud/vue'
+import { NcLoadingIcon as IconLoading, NcEmptyContent } from '@nextcloud/vue'
 import { VList } from 'virtua/vue'
 import { defineComponent } from 'vue'
 import IconContact from 'vue-material-design-icons/AccountMultipleOutline.vue'
@@ -79,6 +79,7 @@ export default defineComponent({
 	components: {
 		EntityPicker,
 		IconContact,
+		IconLoading,
 		MemberGridItem,
 		NcEmptyContent,
 		VList,

src/components/MemberList/MemberListItem.vue

@@ -88,6 +88,7 @@ import {
 	NcActionSeparator,
 	NcActionText,
 	NcAvatar,
+	NcButton,
 	NcListItem,
 } from '@nextcloud/vue'
 import IconCheck from 'vue-material-design-icons/Check.vue'
@@ -113,6 +114,7 @@ export default {
 		NcActionSeparator,
 		NcActionText,
 		NcAvatar,
+		NcButton,
 	},
 
 	mixins: [RouterMixin],

src/components/OrgChart.vue

@@ -34,6 +34,7 @@ import ChartTemplate from './ChartTemplate.vue'
 import LegacyGlobalMixin from '../mixins/LegacyGlobalMixin.js'
 import router from './../router/index.js'
 
+/* eslint-disable vue/one-component-per-file -- ChartTemplate is dynamically mounted via createApp() for d3 node rendering */
 export default {
 	name: 'OrgChart',
 	components: {
@@ -106,8 +107,6 @@ export default {
 		},
 
 		renderChart(data) {
-			// eslint-disable-next-line @typescript-eslint/no-this-alias
-			const that = this
 			if (!this.chartReference) {
 				this.chartReference = new OrgChart()
 			}
@@ -134,7 +133,6 @@ export default {
 						} else {
 							const app = createApp(ChartTemplate, {
 								chartData: d.data,
-								onAvatarClick: (uid) => that.goToContact(uid),
 							})
 							app.use(router)
 							app.mixin(LegacyGlobalMixin)

src/components/Properties/PropertyActions.vue

@@ -47,6 +47,8 @@ export default {
 		},
 	},
 
+	emits: ['delete'],
+
 	methods: {
 		deleteProperty() {
 			this.$emit('delete')

src/components/Properties/PropertyDateTime.vue

@@ -107,6 +107,8 @@ export default {
 		},
 	},
 
+	emits: ['update:value'],
+
 	data() {
 		return {
 			// input type following DatePicker docs

src/components/Properties/PropertyGroups.vue

@@ -62,7 +62,6 @@
 import { NcSelect } from '@nextcloud/vue'
 import naturalCompare from 'string-natural-compare'
 import PropertyTitle from './PropertyTitle.vue'
-import Contact from '../../models/contact.js'
 
 export default {
 	name: 'PropertyGroups',
@@ -83,18 +82,15 @@ export default {
 			required: true,
 		},
 
-		contact: {
-			type: Contact,
-			required: true,
-		},
-
 		// Is it read-only?
 		isReadOnly: {
 			type: Boolean,
 			required: true,
 		},
 	},
 
+	emits: ['update:value'],
+
 	data() {
 		return {
 			localValue: [...this.value].sort(),

src/components/Properties/PropertyMultipleText.vue

@@ -131,7 +131,7 @@
 		<!-- no order enforced: just iterate on all the values -->
 		<template v-else>
 			<div
-				v-for="(value, index) in filteredValue"
+				v-for="(_item, index) in filteredValue"
 				:key="index"
 				class="property__row">
 				<template v-if="(isReadOnly && filteredValue[index]) || !isReadOnly">

src/components/Properties/PropertySelect.vue

@@ -73,6 +73,7 @@ export default {
 	mixins: [PropertyMixin],
 
 	props: {
+		// eslint-disable-next-line vue/no-unused-properties -- consumed by PropertyMixin
 		value: {
 			type: [Object, String, Array],
 			required: true,

src/components/Properties/PropertyText.vue

@@ -182,6 +182,7 @@ export default {
 			default: 'text',
 		},
 
+		// eslint-disable-next-line vue/no-unused-properties -- consumed by PropertyMixin
 		value: {
 			type: String,
 			required: true,