fix(collaborationAutocompletion): replace legacy SHARE_TYPE with ShareType#5419
Merged
Conversation
… ShareType.User Signed-off-by: silver <s.szmajduch@posteo.de>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
hamza221
approved these changes
Jul 1, 2026
Contributor
|
/backport stable8.7 |
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/contacts/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
Contributor
|
/backport to stable8.7 please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inside the Contacts app I could not add members to teams as no users could be found, although they existed.
Claude pointed me to that bug in
collaborationAutocompletion.jswherewindow.OC.Share.SHARE_TYPE_USERwas still being used instead ofShareType.Userandwindow.OC.Share.SHARE_TYPE_REMOTEinstead ofShareType.Remote.🤖 AI (if applicable)