Fix handling of directory names with special characters#3552
Conversation
Signed-off-by: Julian Lehrhuber <jl@lerry.de>
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
This PR fixes an issue that prevents the photos app to display media of directories that contain special characters such as the
&character. When e.g. adding a media folder that is namedPhotos & Videos, the request todav/errors withParse error: xmlParseEntityRef: no name on line XX, column YY, resulting in the "all media" view staying empty and a notification appearing in the top left stating "Error fetching files". This PR resolves this issue by encoding media directory names such that embedding them in the XML payload sent todav/does not yield invalid XML.