Skip to content

fix(OC_Helper): properly calculate quota of shared storages#60341

Open
susnux wants to merge 2 commits into
masterfrom
fix/quota-calc-share
Open

fix(OC_Helper): properly calculate quota of shared storages#60341
susnux wants to merge 2 commits into
masterfrom
fix/quota-calc-share

Conversation

@susnux
Copy link
Copy Markdown
Contributor

@susnux susnux commented May 13, 2026

Summary

First we need to properly handle shared storages,
because there the quota is the quota of the user who owns the nodes, not the user who shared the nodes.

Second if no user can be fetched then we cannot get the global storage info, thus in this case (public share?) we need to safe-guard.

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

- resolves #55659

First we need to properly handle shared storages,
because there the quota is the quota of the user who owns the nodes,
not the user who shared the nodes.

Second if no user can be fetched then we cannot get the global storage
info, thus in this case (public share?) we need to safe-guard.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
@susnux susnux added this to the Nextcloud 34 milestone May 13, 2026
@susnux susnux requested a review from a team as a code owner May 13, 2026 08:41
@susnux susnux added bug 3. to review Waiting for reviews labels May 13, 2026
@susnux susnux requested review from ArtificialOwl, come-nc, icewind1991 and leftybournes and removed request for a team May 13, 2026 08:41
@susnux
Copy link
Copy Markdown
Contributor Author

susnux commented May 13, 2026

/backport to stable33

@susnux susnux requested review from provokateurin and removed request for ArtificialOwl May 13, 2026 08:41
Copy link
Copy Markdown
Member

@provokateurin provokateurin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread lib/private/legacy/OC_Helper.php Outdated
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: setting 'quota_include_external_storage' => true breaks directory share links with Argument #2 ($user) must be of type OCP\\IUser, null given

2 participants