Skip to content

feat(core): app menu polish for NC34#60358

Draft
pringelmann wants to merge 1 commit into
masterfrom
fix/59888/waffle-menu-p2-polish
Draft

feat(core): app menu polish for NC34#60358
pringelmann wants to merge 1 commit into
masterfrom
fix/59888/waffle-menu-p2-polish

Conversation

@pringelmann
Copy link
Copy Markdown
Contributor

Summary

Two follow-ups to #60180:

  • Grid padding moves to the popover wrapper so the top-row hover sits inside the rounded corner.
  • Admin pages (Settings, Apps, Accounts, Help) showed an empty current-app slot. Those entries register as type=settings so they're excluded from the apps initial state. Falls back to settingsNavEntries when no app is active. Logout filtered out defensively.

Aria-label includes the section name so screen readers match the visible text, and settings icons are force-whitened since they ship dark and would otherwise be invisible on the themed header.

Three unit tests cover the fallback path.

Also attempted to unify the two triggers visually. Three approaches, none clean enough before freeze. Parking for a post-NC34 design pass.

Checklist

Signed-off-by: Peter Ringelmann <peter.ringelmann@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant