[stable33] fix(settings): display birthday correctly regardless of browsers timezone#61714
Open
backportbot[bot] wants to merge 2 commits into
Open
[stable33] fix(settings): display birthday correctly regardless of browsers timezone#61714backportbot[bot] wants to merge 2 commits into
backportbot[bot] wants to merge 2 commits into
Conversation
odzhychko
force-pushed
the
backport/61586/stable33
branch
from
b18780f to
2c94283
Compare
odzhychko
approved these changes
Jul 3, 2026
odzhychko
force-pushed
the
backport/61586/stable33
branch
from
2c94283 to
2df9a5a
Compare
`savePrimaryAccountProperty` does only allow `string | boolean`. Incidentally, relying on `@nextcloud/axios` default serialization, `Date`s where serialized using `toISOString`. See https://github.com/axios/axios/blob/a7d7a714498452e611943d9d8e5c2ed8b00aa6b9/lib/helpers/toFormData.js#L134 This change corrects the usage of `savePrimaryAccountProperty` and makes serialization explicit. Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
…zone This also avoid shifting dates after user input. Resolves #49828 Signed-off-by: Oleksandr Dzhychko <hey@oleks.dev>
odzhychko
force-pushed
the
backport/61586/stable33
branch
from
2df9a5a to
31fcb53
Compare
Contributor
|
Ready for review. I'm fairly sure, the failing Cypress tests are not related to the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #61586
Warning, This backport's changes differ from the original and might be incomplete⚠️
Todo
Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.