Skip to content

refactor: map sharing instances to ints, and add instance to indices - #65512

Merged
susnux merged 1 commit into
masterfrom
unified-sharing-indices
Nov 2, 2026
Merged

refactor: map sharing instances to ints, and add instance to indices#65512
susnux merged 1 commit into
masterfrom
unified-sharing-indices

Conversation

@icewind1991

@icewind1991 icewind1991 commented Oct 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member
  • Resolves: #

Summary

  • map instances to ints to optimize db usage, since there are probably only a small number of unique instances anyway
  • add index for owner to share table
  • add instance to unique recipient index

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

@icewind1991 icewind1991 added this to the Nextcloud 36 milestone Oct 14, 2026
@icewind1991
icewind1991 requested review from a team and provokateurin as code owners October 14, 2026 19:09
@icewind1991 icewind1991 added the 3. to review Waiting for reviews label Oct 14, 2026
@icewind1991
icewind1991 requested review from Altahrim, salmart-dev and sorbaugh and removed request for a team October 14, 2026 19:09
@icewind1991

icewind1991 commented Oct 14, 2026

Copy link
Copy Markdown
Member Author

/backport to stable35

@icewind1991 icewind1991 mentioned this pull request Oct 14, 2026
Open
6 of 10 tasks
@icewind1991
icewind1991 force-pushed the unified-sharing-indices branch 4 times, most recently from 3b624cf to 359f94c Compare October 14, 2026 19:51
provokateurin
provokateurin requested changes Oct 27, 2026
View reviewed changes

@provokateurin provokateurin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread apps/sharing/lib/Migration/Version2000Date20261014182648.php Resolved
Comment thread lib/private/Sharing/InstanceMapper.php Resolved
@icewind1991 icewind1991 mentioned this pull request Oct 27, 2026
Draft
@icewind1991
icewind1991 force-pushed the unified-sharing-indices branch from 359f94c to 3c6ad2c Compare October 27, 2026 20:03
provokateurin
provokateurin requested changes Oct 28, 2026
View reviewed changes
Comment thread lib/private/Sharing/InstanceMapper.php Resolved
@provokateurin
provokateurin force-pushed the unified-sharing-indices branch from 3c6ad2c to a251476 Compare November 2, 2026 09:35
@provokateurin
provokateurin requested review from a team as code owners November 2, 2026 09:35
@provokateurin
provokateurin requested review from leftybournes and pabzm and removed request for a team November 2, 2026 09:35
@icewind1991 @provokateurin
refactor: map sharing instances to ints, and add instance to indices
4575695 
Signed-off-by: Robin Appelman <robin@icewind.nl>
@provokateurin
provokateurin force-pushed the unified-sharing-indices branch from a251476 to 4575695 Compare November 2, 2026 10:39
@susnux
susnux disabled auto-merge November 2, 2026 13:37
@susnux
susnux merged commit 2ba1a36 into master Nov 2, 2026
153 of 155 checks passed
@susnux
susnux deleted the unified-sharing-indices branch November 2, 2026 13:37
@backportbot backportbot Bot mentioned this pull request Nov 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@susnux susnux susnux approved these changes
@provokateurin provokateurin provokateurin approved these changes
@Altahrim Altahrim Awaiting requested review from Altahrim Altahrim is a code owner automatically assigned from nextcloud/server-backend
@salmart-dev salmart-dev Awaiting requested review from salmart-dev salmart-dev is a code owner automatically assigned from nextcloud/server-backend
@sorbaugh sorbaugh Awaiting requested review from sorbaugh sorbaugh is a code owner automatically assigned from nextcloud/server-backend
@leftybournes leftybournes Awaiting requested review from leftybournes leftybournes is a code owner automatically assigned from nextcloud/files-backend
@pabzm pabzm Awaiting requested review from pabzm pabzm is a code owner automatically assigned from nextcloud/files-backend

Assignees

@icewind1991 icewind1991

Labels

3. to review Waiting for reviews

Projects

None yet

Milestone

Nextcloud 36

Development

Successfully merging this pull request may close these issues.

3 participants

@icewind1991 @susnux @provokateurin