Repository navigation
fix(Security\Hasher): Guard PASSWORD_ARGON2 constants with defined() check - #65791
Merged
AndyScherzinger merged 1 commit intoOct 30, 2026
Merged
Conversation
hiro-gj
requested review from
Altahrim,
icewind1991,
leftybournes and
provokateurin
and removed request for
a team
October 22, 2026 13:13
6 of 9 tasks
artonge
reviewed
Oct 23, 2026
2 of 8 tasks
artonge
approved these changes
Oct 29, 2026
Collaborator
|
/backport to stable35 |
Collaborator
|
@hiro-gj can you fix the conflicts? |
Contributor
Author
@artonge Sorry! There was an issue with the line endings. https://github.com/nextcloud/server/pull/65791/changes Thanks! |
Collaborator
|
@hiro-gj can you squash your commits and fix the php-cs and rector errors? |
…check Guard constant references with defined() checks so that systems without Argon2 support can safely fall back to bcrypt without fatal errors. Follow-up to nextcloud#64733 Fixes nextcloud#65780 Signed-off-by: hiro-gj <49264814+hiro-gj@users.noreply.github.com>
hiro-gj
force-pushed
the
fix/65780-hasher-argon2
branch
from
October 30, 2026 00:03
ee14649 to
a27f840
Compare
Contributor
Author
AndyScherzinger
approved these changes
Oct 30, 2026
|
Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PASSWORD_ARGON2IDinOCSecurityHasher#65780Summary
Guard
PASSWORD_ARGON2IDandPASSWORD_ARGON2Iconstants withdefined()checks inHasher::hash().On PHP environments compiled without Argon2 support (
--with-password-argon2not enabled), referencing these undefined constants results in a fatal error (Error: Undefined constant "OC\Security\PASSWORD_ARGON2ID") before the bcrypt fallback can be evaluated.Follow-up to #64733
cc @provokateurin
Checklist