Repository navigation
[stable35] chore(deps): bump @nextcloud/dialogs from 7.5.0 to 8.0.0 - #66072
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
github-actions
Bot
changed the title
AndyScherzinger
left a comment
AndyScherzinger
left a comment
There was a problem hiding this comment.
Requesting changes: @nextcloud/dialogs 7.6.0 deliberately reverts the toast rework from 7.5.0 (nextcloud-libraries/nextcloud-dialogs#2712, "considered a breaking change and moved to v8"). The red Playwright test is the symptom, not the problem.
Why CI fails: tests/playwright/support/utils/toast.ts locates toasts by [role="alert"], [role="status"], which the 7.5.0 toasts set. 7.6.0 goes back to toastify-js, which only sets aria-live and no role, so e.g. files: Drag and Drop › ignores dropped folders (legacy File API) never finds its toast.
What merging would regress:
- The user setting for the toast timeout (
apps/theming/src/components/UserSectionToastTimeout.vue, capabilitytheming.toastTimeout) is only consumed bygetToastTimeout()in dialogs 7.5.0. 7.6.0 removes it, so the setting stays in the UI but silently does nothing. - The accessible toasts (
role="alert"/role="status") we adopted with 7.5.0 are lost again. - The toast functions return a Toastify
Toastagain instead of 7.5.0'sToastHandle.
Adjusting the test helper to also match .toastify would turn this green and ship the regressions above, so please do not merge this as is. The accessible toasts and the timeout configuration are back in @nextcloud/dialogs 8.0.0, which is the way forward on master; stable branches should stay on 7.5.0.
|
on stable35 we need v8. |
susnux
changed the title
5ec4260 to
f20fab6
Compare
Bumps [@nextcloud/dialogs](https://github.com/nextcloud-libraries/nextcloud-dialogs) from 7.5.0 to 7.6.0. - [Release notes](https://github.com/nextcloud-libraries/nextcloud-dialogs/releases) - [Changelog](https://github.com/nextcloud-libraries/nextcloud-dialogs/blob/main/CHANGELOG.md) - [Commits](nextcloud-libraries/nextcloud-dialogs@v7.5.0...v7.6.0) --- updated-dependencies: - dependency-name: "@nextcloud/dialogs" dependency-version: 7.6.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
f20fab6 to
9b40ae2
Compare
update to v8 for compatibility with Nextcloud 35+