Skip to content

fix(lostpassword): Avoid having a different error message between expired and invalid - #66308

Merged
cristianscheid merged 2 commits into
masterfrom
fix/fix-lostpassword-token-error
Nov 5, 2026
Merged

cristianscheid merged 2 commits into
masterfrom
fix/fix-lostpassword-token-error

Conversation

@come-nc

@come-nc come-nc commented Nov 4, 2026

Copy link
Copy Markdown
Contributor
  • Resolves: #

Summary

Checklist

AI (if applicable)

  • The content of this PR was partly or fully generated using AI

…ired and invalid

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
@come-nc come-nc added this to the Nextcloud 36 milestone Nov 4, 2026
@come-nc come-nc self-assigned this Nov 4, 2026
@come-nc
come-nc requested a review from a team as a code owner November 4, 2026 15:57
@come-nc come-nc added the 3. to review Waiting for reviews label Nov 4, 2026
@come-nc
come-nc requested review from leftybournes and salmart-dev and removed request for a team November 4, 2026 15:57

@susnux susnux left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI related:

  1. Test\Security\VerificationToken\VerificationTokenTest::testTokenExpired
    Failed asserting that 6 is equal to expected exception code 5.

  2. Test\Security\VerificationToken\VerificationTokenTest::testTokenExpiredByLogin
    Failed asserting that 6 is equal to expected exception code 5.

Signed-off-by: Louis Chmn <louis@chmn.me>
@cristianscheid

Copy link
Copy Markdown
Member

/backport! to stable35

@cristianscheid

Copy link
Copy Markdown
Member

/backport! to stable34

@cristianscheid

Copy link
Copy Markdown
Member

/backport! to stable33

@nextcloud nextcloud deleted a comment from come-nc Nov 5, 2026
@cristianscheid
cristianscheid merged commit ad4cf1a into master Nov 5, 2026
157 of 167 checks passed
@cristianscheid
cristianscheid deleted the fix/fix-lostpassword-token-error branch November 5, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants