-
Notifications
You must be signed in to change notification settings - Fork 784
Validate module spec against JSON schema #7094
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pditommaso
wants to merge
4
commits into
master
Choose a base branch
from
module-validate-schema
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
5712745
Validate module spec against JSON schema
pditommaso b70b1fe
Merge branch 'master' into module-validate-schema
pditommaso 369963f
Use ModuleSchemaValidator.DEFAULT_SCHEMA_URL constant in ModuleSpec.a…
pditommaso 6027327
Detect JSON Schema draft from the loaded schema [ci fast]
pditommaso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
110 changes: 110 additions & 0 deletions
110
modules/nextflow/src/main/groovy/nextflow/module/ModuleSchemaValidator.groovy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| /* | ||
| * Copyright 2013-2026, Seqera Labs | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package nextflow.module | ||
|
|
||
| import java.nio.file.Files | ||
| import java.nio.file.Path | ||
| import java.nio.file.Paths | ||
|
|
||
| import com.fasterxml.jackson.databind.JsonNode | ||
| import com.fasterxml.jackson.databind.ObjectMapper | ||
| import com.networknt.schema.JsonSchema | ||
| import com.networknt.schema.JsonSchemaFactory | ||
| import com.networknt.schema.SpecVersion | ||
| import com.networknt.schema.ValidationMessage | ||
| import groovy.transform.CompileStatic | ||
| import groovy.util.logging.Slf4j | ||
| import nextflow.exception.AbortOperationException | ||
| import org.yaml.snakeyaml.Yaml | ||
|
|
||
| /** | ||
| * Validates a module spec (meta.yml) against the Nextflow module JSON schema. | ||
| * | ||
| * @author Paolo Di Tommaso <paolo.ditommaso@gmail.com> | ||
| */ | ||
| @Slf4j | ||
| @CompileStatic | ||
| class ModuleSchemaValidator { | ||
|
|
||
| static final String DEFAULT_SCHEMA_URL = | ||
| 'https://raw.githubusercontent.com/nextflow-io/schemas/refs/heads/main/module/v1/schema.json' | ||
|
|
||
| private static final ObjectMapper JSON_MAPPER = new ObjectMapper() | ||
|
|
||
| /** | ||
| * Validate a meta.yml file against the JSON schema located at the given | ||
| * URL or local file path. | ||
| * | ||
| * @param metaYaml Path to the meta.yml file to validate | ||
| * @param schemaLocation URL (http/https), file: URI, or local file path of the schema | ||
| * @return List of validation error messages, empty if the spec is valid | ||
| */ | ||
| static List<String> validate(Path metaYaml, String schemaLocation) { | ||
| final schemaText = loadSchema(schemaLocation) | ||
| final factory = JsonSchemaFactory.getInstance(SpecVersion.VersionFlag.V202012) | ||
| final JsonSchema schema | ||
| try { | ||
| schema = factory.getSchema(schemaText) | ||
| } | ||
| catch( Exception e ) { | ||
| throw new AbortOperationException("Invalid module schema at '${schemaLocation}': ${e.message}", e) | ||
| } | ||
|
|
||
| Object yamlData | ||
| try( final stream = Files.newInputStream(metaYaml) ) { | ||
| yamlData = new Yaml().load(stream) | ||
| } | ||
| catch( Exception e ) { | ||
| throw new AbortOperationException("Failed to read module spec '${metaYaml}': ${e.message}", e) | ||
| } | ||
|
|
||
| final JsonNode node = JSON_MAPPER.valueToTree(yamlData) | ||
| final Set<ValidationMessage> messages = schema.validate(node) | ||
| return messages.collect { it.message }.toList() | ||
| } | ||
|
|
||
| static List<String> validate(Path metaYaml) { | ||
| return validate(metaYaml, DEFAULT_SCHEMA_URL) | ||
| } | ||
|
|
||
| /** | ||
| * Load the JSON schema text from a remote URL, file: URI, or local file path. | ||
| * Hard-fails with AbortOperationException on any I/O error. | ||
| */ | ||
| private static String loadSchema(String location) { | ||
| try { | ||
| if( location.startsWith('http://') || location.startsWith('https://') ) { | ||
| final url = new URL(location) | ||
| final conn = url.openConnection() | ||
| conn.setConnectTimeout(10_000) | ||
| conn.setReadTimeout(20_000) | ||
| try( final stream = conn.getInputStream() ) { | ||
| return new String(stream.readAllBytes(), 'UTF-8') | ||
| } | ||
| } | ||
| if( location.startsWith('file:') ) { | ||
| return Files.readString(Paths.get(URI.create(location))) | ||
| } | ||
| return Files.readString(Paths.get(location)) | ||
| } | ||
| catch( Exception e ) { | ||
| throw new AbortOperationException( | ||
| "Failed to load module schema from '${location}': ${e.message}. " + | ||
| "Pass --schema <url-or-local-path> to override.", e) | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.