Skip to content

[stable-34.0] [master] 2003-Account_Settings_Dialog#446

Open
github-actions[bot] wants to merge 19 commits into
stable-34.0from
backport/nmc/390/stable-34.0
Open

[stable-34.0] [master] 2003-Account_Settings_Dialog#446
github-actions[bot] wants to merge 19 commits into
stable-34.0from
backport/nmc/390/stable-34.0

fix

998261c
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Jun 18, 2026 in 7m 59s

Annotations

Check failure on line 80 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory.

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ7VHsBU9vjCgjbaBihn&open=AZ7VHsBU9vjCgjbaBihn&pullRequest=446

Check failure on line 210 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 28 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ7VHsBU9vjCgjbaBihq&open=AZ7VHsBU9vjCgjbaBihq&pullRequest=446

Check failure on line 291 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rewrite the code so that you no longer need this "delete".

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ7VHsBU9vjCgjbaBihu&open=AZ7VHsBU9vjCgjbaBihu&pullRequest=446

Check failure on line 41 in src/gui/nmcgui/nmcaccountsettings.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, or complete the implementation.

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ7VHsAw9vjCgjbaBihk&open=AZ7VHsAw9vjCgjbaBihk&pullRequest=446

Check failure on line 226 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory.

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ7VHsBU9vjCgjbaBihs&open=AZ7VHsBU9vjCgjbaBihs&pullRequest=446

Check warning on line 167 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "layout" is "class QLayout *".

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ7VHsBU9vjCgjbaBihp&open=AZ7VHsBU9vjCgjbaBihp&pullRequest=446

Check failure on line 137 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rewrite the code so that you no longer need this "delete".

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ7VHsBU9vjCgjbaBiho&open=AZ7VHsBU9vjCgjbaBiho&pullRequest=446

Check failure on line 36 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this macro by "const", "constexpr" or an "enum".

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ7VHsBU9vjCgjbaBihm&open=AZ7VHsBU9vjCgjbaBihm&pullRequest=446

Check warning on line 344 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto".

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ7VHsBU9vjCgjbaBihr&open=AZ7VHsBU9vjCgjbaBihr&pullRequest=446

Check warning on line 41 in src/gui/nmcgui/nmcaccountsettings.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const".

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ7VHsAw9vjCgjbaBihl&open=AZ7VHsAw9vjCgjbaBihl&pullRequest=446

Check warning on line 265 in src/gui/nmcgui/nmcaccountsettings.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 36 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function.

See more on https://sonarcloud.io/project/issues?id=nextmcloud_desktop&issues=AZ7VHsBU9vjCgjbaBiht&open=AZ7VHsBU9vjCgjbaBiht&pullRequest=446