feat: BCFTOOLS_PLUGINVCF2TABLE#11219
Open
emmcauley wants to merge 16 commits intonf-core:masterfrom
Open
Conversation
emmcauley
force-pushed
the
em_bcftools_vcf_to_table
branch
2 times, most recently
from
89876cb to
bd12a5c
Compare
emmcauley
force-pushed
the
em_bcftools_vcf_to_table
branch
from
bd12a5c to
a504b29
Compare
SPPearce
requested changes
May 4, 2026
SPPearce
reviewed
May 7, 2026
Comment on lines
+12
to
+14
| tuple val(meta2), path(regions) | ||
| tuple val(meta3), path(targets) | ||
| tuple val(meta4), path(samples) |
Contributor
There was a problem hiding this comment.
Are these likely to be the same file for every sample, or depend on the sample?
Contributor
Author
There was a problem hiding this comment.
they can be either shared or per-sample depending on the context
Contributor
There was a problem hiding this comment.
Hmm, this might be a moot point when we end up using record types SOON (TM), but currently it is probably easier if they are all part of the same tuple I think.
SPPearce
reviewed
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Closes #9224.
This PR adds
bcftools +vcf2tableand tests.topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile condanf-core subworkflows test <SUBWORKFLOW> --profile dockernf-core subworkflows test <SUBWORKFLOW> --profile singularitynf-core subworkflows test <SUBWORKFLOW> --profile conda