fix(kofamscan): migrate to topic versions and add stub testing#11436
Open
HReed1 wants to merge 3 commits intonf-core:masterfrom
Open
fix(kofamscan): migrate to topic versions and add stub testing#11436HReed1 wants to merge 3 commits intonf-core:masterfrom
HReed1 wants to merge 3 commits intonf-core:masterfrom
Conversation
SPPearce
requested changes
Apr 30, 2026
Contributor
SPPearce
left a comment
There was a problem hiding this comment.
If you move the setup block up to the top (outside of the first test) then it will only run once (and won't require code duplication)
SPPearce
requested changes
Apr 30, 2026
Contributor
SPPearce
left a comment
There was a problem hiding this comment.
If you move the setup block up to the top (outside of the first test) then it will only run once (and won't require code duplication)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core modules lint).nextflow run . -profile test,docker --outdir <OUTDIR>).module.htmlis updated unless an exception is made.Description
This PR standardizes the
kofamscanmodule to the newtopic: versionstuple architecture to resolve CI failures and meet project standards.versions.ymlgeneration to tuple emission with dynamic version extraction usingeval.versions.ymllogic.stub:block.nf-core modules lintpass.Part of #4570