Update smoothxg: topic versions, stub block, sanitizeOutput#11448
Update smoothxg: topic versions, stub block, sanitizeOutput#11448HReed1 wants to merge 6 commits intonf-core:masterfrom
Conversation
| tuple val(meta), path("*smoothxg.gfa"), emit: gfa | ||
| path("*.maf") , optional: true, emit: maf | ||
| path "versions.yml" , emit: versions | ||
| tuple val("${task.process}"), val('smoothxg'), eval("smoothxg --version 2>&1 | cut -f 1 -d '-' | cut -f 2 -d 'v'"), topic: versions, emit: versions_smoothxg |
There was a problem hiding this comment.
Can you simplify this into just one command, not two cut commands.
| then { | ||
| assertAll( | ||
| { assert process.success }, | ||
| // { assert snapshot(process.out).match() } // SMOOTHXG is never deterministic |
There was a problem hiding this comment.
This is a bit strange, it says it is not deterministic, but your tests are passing?
8d06c8d to
101e01c
Compare
|
@SPPearce Thanks for the review! I've addressed both of your points in the upcoming push:
I'll push these fixes up now. Let me know if you see anything else! |
…e snapshots - main.nf: emit: versions -> emit: versions_smoothxg - meta.yml: output key versions: -> versions_smoothxg: - main.nf/meta.yml: simplify eval string to use sed instead of dual cuts - tests/main.nf.test.snap: regenerate snapshots Local lint: 54/0. Local nf-test: 3/3 passed.
04b7fe0 to
a860fc7
Compare
|
I've pushed the requested standardizations. Note for Maintainers: The current Because of this, the GitHub Actions GitHub Actions Error Log (Apptainer Install Failure): To ensure this module is sound and ready to merge once Canonical recovers, I bypassed the failing GitHub Actions queue and validated AWS Ephemeral Cloud Runner Validation: Bringing this directly to your attention @SPPearce as many of the PR's I'm working on will have this issue. For the branches with singularity being the only failures on the github CI pipelines. |
PR checklist
--profile docker,wavetests.nf-core modules lint).nf-test test).Description of changes
Migrates the smoothxg module to the nf-core v4.0.1 architecture:
versions.ymlfile emission with dynamiceval()tuple emission on thetopic: versionschannel.stub:block for CI/CD stub-run support.sanitizeOutput(process.out)per nf-test best practices.output: versions_smoothxgandtopics: versionssections.Part of the v4.0.1 standardization effort tracked in #11323.
Part of #4570