Add fgumi/extract#11546
Draft
atrigila wants to merge 12 commits intonf-core:masterfrom
Draft
Conversation
SPPearce
reviewed
May 7, 2026
SPPearce
reviewed
May 7, 2026
Contributor
SPPearce
left a comment
SPPearce
left a comment
There was a problem hiding this comment.
Oh, ok, my apologies, I thought it was taking ubam.
You can remove the default prefix then, if it isn't going to collide within the module.
You shouldn't need to set prefix in the test at that point though.
SPPearce
reviewed
May 7, 2026
Comment on lines
+23
to
+25
| if (!args.contains('--sample') || !args.contains('--library')) { | ||
| error("fgumi extract requires both --sample and --library to be supplied via task.ext.args") | ||
| } |
Contributor
There was a problem hiding this comment.
Hmm, if these are required arguments, they should probably be part of the input tuple.
Contributor
There was a problem hiding this comment.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For: nf-core/smrnaseq#535