Add options to specify user agent and keep inner HTML - #44
Open
jakewilliami wants to merge 4 commits into
Open
Conversation
We need a way to be able to pass optional settings to Page, in order to change its behaviour.
Many websites will now require a user agent. Even Wikipedia is blocking our requests in our unit tests. We now allow a user agent to be set for HTTP queries. We also specify a default user agent to use if none is set by the user.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR primarily adds an option to retain the inner HTML of each row of the table (closing #37).
However, unit tests were failing, in part due to Wikipedia blocking requests without a valid user agent (an error which I have encountered when trying to use this package in the past). So, I thought it appropriate to implement another option to allow the user agent to be configurable, and to set a default user agent for all requests to minimise the likelihood that requests are blocked.
So the API now allows for amended options to every relevant call. For example: