Remove AMPLITUDE_AND_PHASE_FLATNESS deembedding type enum from NI-RFSA and NI-RFSG - #1284
Merged
raghavanv merged 1 commit intoAug 13, 2026
Conversation
raghavanv
requested review from
astarche,
maxxboehme and
reckenro
as code owners
August 10, 2026 18:38
astarche
approved these changes
Aug 10, 2026
reckenro
approved these changes
Aug 11, 2026
maxxboehme
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
Removes the
AMPLITUDE_AND_PHASE_FLATNESSDeembeddingTypeenum value from both NI-RFSA and NI-RFSG, reverting that portion of #1277. TheAMPLITUDE_FLATNESSvalue is retained.Removed values:
DeembeddingType:AMPLITUDE_AND_PHASE_FLATNESS=3904DeembeddingType:AMPLITUDE_AND_PHASE_FLATNESS=25004Files changed (mirrors the 6 files touched by #1277):
source/codegen/metadata/nirfsa/enums.py,source/codegen/metadata/nirfsg/enums.pygenerated/nirfsa/nirfsa.proto,generated/nirfsg/nirfsg.protoimports/include/niRFSA.h,imports/include/niRFSG.hWhy should this Pull Request be merged?
The amplitude-and-phase-flatness de-embedding mode should not be exposed through the gRPC interface for these drivers, so this removes the enum value that was added in #1277 while leaving amplitude-flatness support in place.
What testing has been done?
.protofiles stayed in sync.cmake --build) — all 101 targets compiled and linked with 0 errors.UnitTestsRunner.exe— 505 tests across 26 suites, all passing.