Repository navigation
fix(desktop): dev runs the core from dist/client.js, not the removed dist/index.js - #630
Merged
Merged
Conversation
…dist/index.js coreEntryCandidates' dev fallback still pointed at the repo's dist/index.js, which stopped existing when the server moved into @agentgem/app (the entry is dist/client.js, the same file bundle-core.mjs bundles). So `pnpm -C desktop dev` failed with "AgentGem core not found", and 8 server.test.ts tests failed the same way. CI does not run the desktop suite, so nothing flagged it. Packaged apps were unaffected: they load resources/core/index.mjs. Updated core.test.ts's expected candidate first (red), then the path. Desktop suite 76/76, including the test that boots the real core from the dev candidate, fetches the UI, and checks the port is released. Desktop tsc clean. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop app's dev fallback in
coreEntryCandidatesstill pointed atdist/index.js. That file was removed when the server moved into@agentgem/app; the entry is nowdist/client.js, which is also whatbundle-core.mjsbundles. Because of this:pnpm -C desktop devfailed with "AgentGem core not found".desktop/src/__tests__/server.test.tsfailed with the same error. CI doesn't run the desktop suite, so nothing caught it.Packaged apps are unaffected, because they load
resources/core/index.mjs.Fix: the dev candidate is now
dist/client.js. I updatedcore.test.tsfirst and watched it fail.Verified: the desktop suite passes (76/76). That includes the test that starts the real core from the dev candidate, gets the page, and checks the port is released afterward. Desktop
tscis clean.🤖 Generated with Claude Code