Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1555.
An all-false mask or a selection that removes every greyordinate cannot currently produce a BrainModelAxis: its surface/volume mask properties call np.vectorize without an output type, which raises on empty input.
Specify the boolean output type for both mask properties and let iter_structures finish without indexing the first element when the axis is empty. Tests cover surface and volume masks, an empty slice, an all-false selection, and concatenating the empty result with a non-empty axis.
Validation: all four new cases fail on the base. The CIFTI-2 suite passes 114 tests with 16 optional-data skips and one expected failure. Ruff 0.15.15 lint and formatting pass for both changed files.