docs(changelog): add v1.20.0 entry#291
Merged
Merged
Conversation
ErickXavier
commented
Jul 17, 2026
ErickXavier
left a comment
Collaborator
Author
There was a problem hiding this comment.
APPROVED — QA GATE (T9 / NOJS-279)
Verified:
- CHANGELOG [1.20.0] entry follows the repo's Keep a Changelog conventions exactly (inline compare link
v1.19.0...v1.20.0, em-dash date 2026-07-17, intro narrative +### Added/### Fixedsections matching the [1.19.0] house style;[Unreleased]link advanced tov1.20.0...HEAD). - Every claim in the entry is TRUE against
git log v1.19.0..feat/NOJS-270and merged PRs #284–#290. No invented features. The only unmapped commits are internal bench chores, correctly omitted. - package-lock.json diff touches ONLY the two root version fields (1.16.1 → 1.20.0, lines 3 and 9), now consistent with package.json and
src/index.js(both 1.20.0). No dependency churn. - Single conventional commit (
docs(changelog): add v1.20.0 entry), author Erick Xavier, no AI attribution. - /code-review pipeline (8 finder angles + verification): 1 confirmed finding, non-blocking (below). All other candidates refuted.
Non-blocking (wording, fix at leisure): the bullet says "validate sse-limit is a positive integer", but src/directives/sse.js:62-65 accepts 0 (treated as no-cap) and rejects only negative/non-numeric values — the code's own warning says "non-negative integer". Suggest changing the bullet to "non-negative integer".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[1.20.0] - 2026-07-17entry to CHANGELOG.md documenting the SSE directive feature (Added section with full attribute API breakdown), SSE-related fixes, and E2E test fixesv1.20.0...HEADpackage-lock.jsonroot version from 1.16.1 to 1.20.0 (2 fields only, no dependency churn)