Skip to content

chore: update to vp@0.1.8 #689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fengmk2 merged 3 commits into from
Mar 12, 2026
+238 −214
Merged

chore: update to vp@0.1.8 #689

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
40bc325
chore: update to vp@0.1.8
fengmk2 Mar 12, 2026
35b203f
FIXUP
fengmk2 Mar 12, 2026
30c4d4d
Merge branch 'master' into vp-0.1.8
fengmk2 Mar 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .vscode/extensions.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"recommendations": ["VoidZero.vite-plus-extension-pack"]
}
21 changes: 21 additions & 0 deletions .vscode/settings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
{
"editor.formatOnSave": true,
"files.insertFinalNewline": true,
"files.trimFinalNewlines": true,
"[javascript]": {
"editor.defaultFormatter": "oxc.oxc-vscode"
},
"[typescriptreact]": {
"editor.defaultFormatter": "oxc.oxc-vscode"
},
"[typescript]": {
"editor.defaultFormatter": "oxc.oxc-vscode"
},
"[json]": {
"editor.defaultFormatter": "oxc.oxc-vscode"
},
Comment on lines +5 to +16
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workspace settings enforce oxc.oxc-vscode as the default formatter for JS/TS/JSON, but the workspace extension recommendations do not include that extension. This can lead to VS Code showing a missing formatter and formatting-on-save failing for contributors. Consider adding the Oxc extension ID to .vscode/extensions.json (or switching the defaultFormatter to an extension that is already recommended).

Suggested change
"[javascript]": {
"editor.defaultFormatter": "oxc.oxc-vscode"
},
"[typescriptreact]": {
"editor.defaultFormatter": "oxc.oxc-vscode"
},
"[typescript]": {
"editor.defaultFormatter": "oxc.oxc-vscode"
},
"[json]": {
"editor.defaultFormatter": "oxc.oxc-vscode"
},

Copilot uses AI. Check for mistakes.
"typescript.preferences.importModuleSpecifierEnding": "js",
"typescript.reportStyleChecksAsWarnings": false,
"typescript.updateImportsOnFileMove.enabled": "always",
"typescript.experimental.useTsgo": true
}
2 changes: 1 addition & 1 deletion CLAUDE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ Vite+ automatically detects and wraps the underlying package manager such as pnp
- [ ] Run `vite lint`, `vite fmt`, and `vite test` to validate changes.
<!--VITE PLUS END-->

<!--injected-by-vite-plus-v0.1.4-->
<!--injected-by-vite-plus-v0.1.8-->
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

It appears the new documentation for vite-plus has been injected, but the old version is still present in the file from lines 86-138. This has resulted in duplicated sections with conflicting information (e.g., using vite vs. vp commands). To avoid confusion, the old section should be removed.

Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The injected marker was bumped to v0.1.8, but the repo still depends on vite-plus/@voidzero-dev/vite-plus-* ^0.1.6 (see package.json and pnpm-lock.yaml). If this PR is intended to upgrade to vp/vite-plus 0.1.8, the dependency + lockfile should be updated as well; otherwise this marker should stay at 0.1.6 to avoid misleading tooling/docs.

Copilot uses AI. Check for mistakes.
<!--VITE PLUS START-->
Comment on lines 136 to 141
Copy link

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CLAUDE.md now contains an older Vite+ section that still instructs using the vite CLI (ending at <!--VITE PLUS END-->) immediately followed by the newly injected vp-based section. This creates conflicting guidance in the same document. Consider removing or updating the pre-injection vite section so the doc only describes the current vp workflow.

Copilot uses AI. Check for mistakes.

# Using Vite+, the Unified Toolchain for the Web
Expand Down
Loading