Skip to content

Change view type annotation to Uint8Array #63130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
debojeetmitra wants to merge 2 commits into
base: main
Choose a base branch
from
+1 −1
Open

Change view type annotation to Uint8Array #63130

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d7c0a9a
Change view type annotation to Uint8Array
debojeetmitra May 5, 2026
e397116
webstreams: narrow ReadableStreamBYOBRequest.view to Uint8Array
debojeetmitra May 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions lib/internal/webstreams/readablestream.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -664,9 +664,9 @@
}

/**
* @readonly
* @type {ArrayBufferView}
*/
* @readonly

Check failure on line 667 in lib/internal/webstreams/readablestream.js

View workflow job for this annotation

GitHub Actions / lint-js-and-md 

Expected JSDoc block to be aligned
* @type {Uint8Array}
*/
get view() {
if (!isReadableStreamBYOBRequest(this))
throw new ERR_INVALID_THIS('ReadableStreamBYOBRequest');
Expand Down
Loading