Repository navigation
desktop: paint tooltips with the opaque surface colour, fix #98 - #99
Merged
Merged
Conversation
The settings hints and the conversation subject tooltip used bg-raised, which is 40% opaque in Meron Dark, Indigo Dark and custom dark themes, so the content under them showed through. bg-chats is opaque in every theme and is what the menus and other floating panels already use. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #98. The ⓘ hints in Settings and the full-subject tooltip of a conversation were see-through in Meron Dark, Indigo Dark and custom dark themes, so the rows under them showed through. They now use the surface colour, which is opaque in every theme.
What changed
InfoTip.tsxandConversationSubject.tsx: the tooltip background isbg-chatsinstead ofbg-raised.bg-raisedis 40% opaque in those themes, which suits inputs and cards on a surface but not something floating over other content.bg-chatsis what the menus and other floating panels already use.Testing
InfoTip.test.tsxand a case inConversationSubject.test.tsxcheck that each tooltip usesbg-chats, notbg-raised(both seen failing before the change). A case inthemes.test.tschecks that the surface colour is opaque in every built-in theme and in derived light and dark themes.bun run test:frontend: typecheck clean, 1122 pass, 1 skip, 2 fail. The two failures areComposer > drains and discards when the tab strip closes the composerandComposer > discards the copy a failed save may have written after the tab closed, which fail the same way onmain(8cfb6ad4) in a full run and pass whenComposer.test.tsxruns alone.mainwith this change: the Settings hints are solid with a custom dark theme. Not checked on macOS or Windows.