Skip to content

fix: highlight scatter axes on facet inputs focus #2484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ghostdevv merged 2 commits into from
Apr 12, 2026
+4 −2
Merged

fix: highlight scatter axes on facet inputs focus #2484

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2f3b6e6
fix: highlight scatter axes on facet inputs focus
graphieros Apr 12, 2026
79220f2
fix: add missing mouseleave
graphieros Apr 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions app/components/Compare/FacetScatterChart.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,8 @@ function toggleAxisHighlight(state: AxisHighlight) {
@change="step += 1"
@mouseenter="toggleAxisHighlight('x')"
@mouseleave="toggleAxisHighlight(null)"
@blur="toggleAxisHighlight(null)"
@focusin="toggleAxisHighlight('x')"
@focusout="toggleAxisHighlight(null)"
/>
<SelectField
class="w-full"
Expand All @@ -322,8 +323,9 @@ function toggleAxisHighlight(state: AxisHighlight) {
block
@change="step += 1"
@mouseenter="toggleAxisHighlight('y')"
@mouseleave="toggleAxisHighlight(null)"
@blur="toggleAxisHighlight(null)"
@focus="toggleAxisHighlight('y')"
@focusin="toggleAxisHighlight('y')"
@focusout="toggleAxisHighlight(null)"
Comment thread
coderabbitai[bot] marked this conversation as resolved.
/>
</div>

Expand Down
Loading