-
-
Notifications
You must be signed in to change notification settings - Fork 432
chore: fix spelling & grammar #2651
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
b13beb8
d651276
a3d0f81
5849629
60b3aa4
00221e9
71e70a7
7535234
f79b699
36002f5
aba7b9e
cba4e3f
9502691
21f746d
f724886
d501584
d0a0ada
75a4a04
e8d802c
6a7fae4
7bcc76c
1b2e99c
3b6247e
c0d6d07
65c7590
bf5db6a
cf1d084
55994e6
6e5ddbc
cdb5d13
92925c9
ab93209
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -1,6 +1,6 @@ | ||||
| #!/usr/bin/env node | ||||
| /** | ||||
| * Mock connector CLI — starts a pre-populated mock server for developing | ||||
| * Mock connector CLI — starts a prepopulated mock server for developing | ||||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm making this suggestion because the CONTRIBUTING guide uses the Line 30 in 17ea220
(It's mostly an outlier in that regard -- the rest of the project feels like it's en-GB, but I'm favoring contributing since I was expected to read it.) |
||||
| * authenticated features without a real npm account. | ||||
| */ | ||||
|
|
||||
|
|
@@ -25,7 +25,7 @@ function generateToken(): string { | |||
| } | ||||
|
|
||||
| /** | ||||
| * Pre-populate with sample data using real npm orgs so the registry | ||||
| * Prepopulate with sample data using real npm orgs so the registry | ||||
| * API calls don't 404. Members/teams are fictional. | ||||
| */ | ||||
| function populateDefaultData(stateManager: MockConnectorStateManager): void { | ||||
|
|
@@ -107,7 +107,7 @@ const main = defineCommand({ | |||
| }, | ||||
| empty: { | ||||
| type: 'boolean', | ||||
| description: 'Start with empty state (no pre-populated data)', | ||||
| description: 'Start with empty state (no prepopulated data)', | ||||
| default: false, | ||||
| }, | ||||
| }, | ||||
|
|
@@ -130,7 +130,7 @@ const main = defineCommand({ | |||
|
|
||||
| if (!empty) { | ||||
| populateDefaultData(stateManager) | ||||
| p.log.info(`Pre-populated with sample data for ${styleText('cyan', npmUser)}`) | ||||
| p.log.info(`Prepopulated with sample data for ${styleText('cyan', npmUser)}`) | ||||
| p.log.info(styleText('dim', ` Orgs: @nuxt (4 members, 3 teams), @unjs (2 members, 1 team)`)) | ||||
| p.log.info(styleText('dim', ` Packages: @nuxt/kit, @nuxt/schema, @unjs/nitro`)) | ||||
| } else { | ||||
|
|
||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,7 @@ | ||
| import { CACHE_MAX_AGE_ONE_HOUR, NPM_REGISTRY } from '#shared/utils/constants' | ||
| import { FetchError } from 'ofetch' | ||
|
|
||
| // Validation pattern for npm org names - url-sage symbold and not start with a dot (incl. ~test24214. or -ex~-) | ||
| // Validation pattern for npm org names - url-sage symbol and not start with a dot (incl. ~test24214. or -ex~-) | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It's possible that
jsoref marked this conversation as resolved.
|
||
| const NPM_ORG_NAME_RE = /^[\w~-][\w.~-]*$/ | ||
|
|
||
| function validateOrgName(name: string): void { | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While
Date for the noodlereads properly in English,Date to for the noodlereally doesn't. I'm suggesting adding`to make it readable...