Skip to content

chore: improve text#2655

Merged
graphieros merged 10 commits intonpmx-dev:mainfrom
jsoref:cleanup
Apr 29, 2026
Merged

chore: improve text#2655
graphieros merged 10 commits intonpmx-dev:mainfrom
jsoref:cleanup

Conversation

@jsoref
Copy link
Copy Markdown
Contributor

@jsoref jsoref commented Apr 29, 2026

🔗 Linked issue

🧭 Context

📚 Description

jsoref added 7 commits April 29, 2026 10:14
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
per coderabbitai npmx-dev#2651 (review)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
per coderabbitai npmx-dev#2651 (review)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
per coderabbitai npmx-dev#2651 (review)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
per coderabbitai npmx-dev#2651 (review)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
per coderabbitai npmx-dev#2651 (review)

Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com>
@vercel
Copy link
Copy Markdown

vercel Bot commented Apr 29, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
npmx.dev Ready Ready Preview, Comment Apr 29, 2026 3:09pm
2 Skipped Deployments
Project Deployment Actions Updated (UTC)
docs.npmx.dev Ignored Ignored Preview Apr 29, 2026 3:09pm
npmx-lunaria Ignored Ignored Apr 29, 2026 3:09pm

Request Review

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 29, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 56daec47-d614-4b30-9030-b81477da044c

📥 Commits

Reviewing files that changed from the base of the PR and between 86bdf90 and e4dcdba.

📒 Files selected for processing (1)
  • server/api/auth/session.delete.ts
✅ Files skipped from review due to trivial changes (1)
  • server/api/auth/session.delete.ts

📝 Walkthrough

Summary by CodeRabbit

  • Documentation

    • Clarified metric docs: coefficient of variation unit described as normalised 0–1.
    • Improved grammar and wording across inline docs; clarified cache-first behaviour and caller responsibilities in package like/lookup flows.
    • Minor comment wording fixes for session and organisation-name validation notes.
  • Refactor

    • Consolidated duplicated internal package-name parsing into a shared helper; behaviour preserved.

Walkthrough

Minor non-functional edits: documentation and comment wording fixes across multiple files, plus a small internal refactor that extracts duplicated package basename logic into a new non-exported helper in app/utils/run-command.ts. All changes preserve existing behaviour.

Changes

Cohort / File(s) Summary
Docs & comments
app/utils/charts.ts, server/api/auth/session.delete.ts, server/api/registry/org/[org]/packages.get.ts, server/utils/atproto/utils/likes.ts
Grammar and wording corrections in JSDoc and inline comments (e.g., coefficientOfVariation unit changed to 0–1, typo/punctuation fixes, regex description reworded, clarified assumptions). No behavioural changes.
Run-command refactor
app/utils/run-command.ts
Added a non-exported getPackageBaseName helper to centralise scoped-package basename extraction; getExecutableInfo and getRunCommandParts now call this helper instead of duplicating splitting logic. No API/signature changes and behaviour unchanged.

Possibly related PRs

Suggested reviewers

  • graphieros

Important

Pre-merge checks failed

Please resolve all errors before merging. Addressing warnings is optional.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'chore: improve text' is vague and generic, failing to specify what text improvements are being made or which components are affected. Consider a more descriptive title that mentions specific improvements, such as 'chore: fix grammar and terminology in charts, auth, registry, and likes utilities'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description check ✅ Passed The description is related to the changeset, referencing linked issues and prior code review suggestions that motivated the text improvements across multiple files.
Linked Issues check ✅ Passed The pull request successfully addresses issue #2654 by correcting text improvements across five files: fixing grammar in charts documentation, refactoring package name logic with better comments, correcting grammar in auth session comments, fixing terminology in registry comments, and clarifying JSDoc in likes utilities.
Out of Scope Changes check ✅ Passed All changes are in-scope, consisting of documentation, comments, and inline clarifications without modifying runtime logic or control flow as intended for this text improvement PR.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@app/utils/run-command.ts`:
- Line 21: The current basename expression (packageName.startsWith('@') ?
packageName.split('/')[1] : packageName) can return undefined for malformed
scoped names like "@scope"; update the logic in app/utils/run-command.ts to
guard the split result: compute const parts = packageName.split('/'); if
packageName.startsWith('@') return parts.length > 1 ? parts[1] : packageName;
else return packageName; this ensures a string is always returned and preserves
type-safety for the packageName handling.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ea53222a-0ce6-479b-a905-6c25402b7818

📥 Commits

Reviewing files that changed from the base of the PR and between d7511ce and 6b3d3d6.

📒 Files selected for processing (5)
  • app/utils/charts.ts
  • app/utils/run-command.ts
  • server/api/auth/session.delete.ts
  • server/api/registry/org/[org]/packages.get.ts
  • server/utils/atproto/utils/likes.ts

Comment thread app/utils/run-command.ts
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 29, 2026

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
app/utils/run-command.ts 0.00% 3 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

Comment thread app/utils/run-command.ts Outdated
Co-authored-by: Roman <dev@rman.dev>
Comment thread server/api/registry/org/[org]/packages.get.ts Outdated
Comment thread server/api/auth/session.delete.ts Outdated
Comment thread app/utils/charts.ts Outdated
@graphieros graphieros added this pull request to the merge queue Apr 29, 2026
Merged via the queue into npmx-dev:main with commit 5eab00c Apr 29, 2026
22 checks passed
@jsoref jsoref deleted the cleanup branch April 29, 2026 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Minor issues identified by coderabbitai

3 participants