fix: restore maximumFractionDigits: 0 on sparkline data label formatter#2657
fix: restore maximumFractionDigits: 0 on sparkline data label formatter#26572u841r wants to merge 2 commits intonpmx-dev:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughSummary by CodeRabbit
WalkthroughRestores the Changes
Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |
|
Hello! Thank you for opening your first PR to npmx, @2u841r! 🚀 Here’s what will happen next:
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
🔗 Linked issue
Closes #2656
🧭 Context
PR #2556 added
Math.ceilinapplyDataCorrectionto fix decimal numbers in the weekly downloads label, but also removedmaximumFractionDigits: 0from the formatter inWeeklyDownloadStats.vue— which was actually the effective guard.VueUiSparklinedoes its own internal interpolation and passes float values directly todataLabel.formatter, bypassingapplyDataCorrectionentirely. WithoutmaximumFractionDigits: 0, those floats render as1,195,399.72instead of1,195,400.📚 Description
Restore
maximumFractionDigits: 0on theuseNumberFormattercall used for the sparkline data label. One-line change.