consumer: reuse lookupd http client#333
Merged
Merged
Conversation
ploxiln
reviewed
Sep 28, 2021
ploxiln
reviewed
Sep 28, 2021
ploxiln
reviewed
Sep 28, 2021
ploxiln
reviewed
Sep 28, 2021
ploxiln
reviewed
Sep 28, 2021
Contributor
Author
|
@ploxiln Thank you for your review, i have finished these modifications, please review it again. |
ploxiln
reviewed
Sep 29, 2021
| #### Misc. | ||
|
|
||
| Un-exported `NewDeadlineTransport` and `ApiRequest`, which never should have been exported in the | ||
| Un-exported `ApiRequest`, which never should have been exported in the |
Member
There was a problem hiding this comment.
you can leave this as it was; it's still true that NewDeadlineTransport was un-exported (and then now has been un-existed ;)
Member
There was a problem hiding this comment.
If you undo this little change to UPGRADING, and squash down to one commit (with cleaned-up commit message), I'll merge.
ploxiln
reviewed
Sep 29, 2021
| Timeout: r.config.LookupdPollTimeout, | ||
| KeepAlive: 30 * time.Second, | ||
| }).DialContext, | ||
| ResponseHeaderTimeout: r.config.LookupdPollTimeout, |
Member
There was a problem hiding this comment.
This seems redundant with the http.Client Timeout but I guess it's fine.
(Dialer Timeout above could probably be a shorter default, probably matching the 10s TLSHandshakeTimeout below. But again, I guess it's fine, doesn't really hurt.)
Contributor
Author
|
emmm, can request a review to other people? @ploxiln |
ploxiln
force-pushed
the
perfHTTPTransport
branch
from
October 17, 2021 17:20
d391d2a to
c238b8d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After some wrong happend on my machine, i found there are many
TIME_WAITstatus.I have many nsqd topics and n consumers, consumer making http request which not using
Keep-Alivecauses this problem.Solution