nsqadmin: add option to skip resolving on startup#1329
Open
martin-sucha wants to merge 1 commit into
Open
Conversation
When running nsqlookupd in Kubernetes and pointing to a specific identity of a pod from statefulset, the DNS name is not resolvable if the pod is not currently scheduled. The lookup check currently causes nsqadmin to exit during startup even if only one of the listed nsqlookupd instances is not resolvable. I want nsqadmin to always start. If no lookupd instances are currently resolvable/reachable that fact will be visible in the user interface.
Author
|
ready for review |
Member
|
Hey @martin-sucha thanks for the PR. This code path ultimately just validates that we have a proper hostname or IP address - I agree that the resolution of the hostname is probably not something we need to fatally exit on. So, I don't think the answer here is a new command line flag, but rather validation of the format and not the name resolution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running nsqlookupd in Kubernetes and pointing to a specific
identity of a pod from statefulset, the DNS name is not resolvable
if the pod is not currently scheduled.
The lookup check currently causes nsqadmin to exit during startup
even if only one of the listed nsqlookupd instances is not resolvable.
I want nsqadmin to always start. If no lookupd instances are currently
resolvable/reachable that fact will be visible in the user interface.