apps/nsqd: initialize nsqd in Init(); move signal handling to go-svc#1361
Merged
Conversation
Member
Author
|
Depends on judwhite/go-svc#28 |
ploxiln
reviewed
Aug 15, 2021
ploxiln
approved these changes
Aug 15, 2021
ploxiln
left a comment
ploxiln
left a comment
Member
There was a problem hiding this comment.
This looks good to me.
We'll need some go-svc updates for it, obviously :)
ploxiln
reviewed
Aug 15, 2021
mreiferson
force-pushed
the
windows-crash
branch
from
August 15, 2021 18:33
9b25717 to
70c4c39
Compare
Member
Author
|
I've rebased and added acc2061, which will allow us to make progress on a build without waiting for upstream go-svc. PTAL |
Merged
mreiferson
force-pushed
the
windows-crash
branch
from
August 15, 2021 18:54
acc2061 to
839a4fa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This continues to clean up from #1331 and also fixes #1359