nsqd: fix Stats() only returning one pub count when client publishes to multiple topics#1525
Open
troclaux wants to merge 1 commit into
Open
nsqd: fix Stats() only returning one pub count when client publishes to multiple topics#1525troclaux wants to merge 1 commit into
troclaux wants to merge 1 commit into
Conversation
troclaux
force-pushed
the
fix/stats-multi-topic-pubcounts
branch
from
75c7c37 to
6e28916
Compare
…to multiple topics clientV2.Stats() builds a PubCounts slice by ranging over the pubCounts map. A spurious break statement exited the loop after appending the first entry, so only a single topic's count was ever recorded regardless of how many topics the client had published to. Remove the break so the loop collects every matching entry. Fixes nsqio#1492
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
clientV2.Stats()builds thePubCountsslice by ranging over the internalpubCountsmap. A spuriousbreakon line 325 ofclient_v2.goexits the loop immediately after appending the first matching entry, so only one topic's count is ever returned — even when the client has published to multiple topics.Reported in #1492.
Before:
After:
Fix
Remove the
break. The existingcontinuealready handles thetopicNamefilter; thebreakserves no purpose and was causing the data loss.Test
Added
TestStatsMultiTopicPubCountstonsqd/stats_test.gowhich:PublishedMessagefor two different topicsStats("")