Fix/release build expo#408
Open
HuuNguyen312 wants to merge 10 commits into
Open
Conversation
iPhone HDR .MOV uses video/dolby-vision mime which has no
standalone Android decoder, so createDecoderByType throws
"Failed to initialize video/dolby-vision". DV profiles 8.x
carry an HEVC base layer, so remap mime to video/hevc before
configuring the decoder. Reject profile 5 (0x20) explicitly
since it has no HEVC fallback.
Perf, bundled to land with the codec rework:
- Pick HW AVC encoder via MediaCodecList(ALL_CODECS), blacklist
c2.qti.avc.encoder (corrupt MP4 on Mac/iOS).
- Feed decoder until input slots drain instead of one sample
per loop; unblocks parallel decode-render-encode.
- Drop decoded frames whose PTS precedes the next target slot
when source fps exceeds output fps.
- Encoder: VBR + KEY_PRIORITY=0 + KEY_OPERATING_RATE=MAX to
unthrottle HW codec scheduling.
- Route SurfaceTexture onFrameAvailable to a dedicated
HandlerThread so awaitNewImage stops contending with the
main/JS thread.
- Skip StreamableVideo rewrite unless caller passed a
streamableFile; halves disk I/O for chat uploads.
Android: extract METADATA_KEY_LOCATION and write an Apple-style "©xyz" udta atom into the muxed MP4 so geotags survive transcoding. iOS: forward asset.metadata plus every available metadata format to the AVAssetExportSession so location, creation date, and other tags are retained in the exported file. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
- fps: derive from frame_count/duration when CAPTURE_FRAMERATE absent. Cap 30→60. Drop-gate only when source>target, anchor to ideal grid. - bitrate: WhatsApp envelope (~1.5 Mbps @ 720p). Android+iOS sync. - GPS: LocationExtractor walks MP4 — ©xyz, loci, iTunes meta/keys+ilst, SEF trailer regex. Writer ©xyz moved to LocationBox class. - teardown: runCatching every dispose step. join() OutputSurface thread after quitSafely to avoid SIGABRT on stale pthread_t. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…encoder/teardown - LocationExtractor/Compressor: log only location presence + source, never the ISO 6709 coordinate string (xyz/itunes/loci/SEF/resolved values) - Compressor: preflight Dolby Vision profile 5 before allocating muxer/encoder/EGL surfaces and drop the throw from prepareDecoder, so the unsupported case no longer leaks codec/GL resources on bail-out - Compressor: restore always-on streamable rewrite (moov atom to front) for default output to preserve progressive playback (revert behavior change) - CompressorUtils/Compressor: make VBR/priority/operating-rate throughput tuning optional and fall back to a default-rate-control configure when an encoder rejects the tuned format - Compressor: release partially-initialized encoder/decoder/EGL surfaces on any setup failure or in-loop throw (dispose tolerates null handles) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MP4Builder opened its FileOutputStream/FileChannel in createMovie() but only closed them in finishMovie(). Any failure between muxer creation and a successful finishMovie() leaked the output file handle. - Add idempotent MP4Builder.close() to release streams without finalizing - createMovie() now closes its own streams if header writing throws - Compressor closes the muxer in the setup/in-loop catch, the finishMovie catch, and the outer catch (processAudio/extractor.release failures) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The `Compressor` HybridObject implementation is instantiated from C++/JNI by class name (NitroCompressorOnLoad.cpp `kJavaDescriptor`). R8 can't see that reference, so in release builds it stripped `HybridCompressor` — the generated `HybridCompressorSpec` carries `@DoNotStrip @Keep`, but the hand-written impl did not. Result: the module worked in debug but appeared "not linked" in release (numandev1#406). Annotate `HybridCompressor` with `@DoNotStrip @Keep`, the same convention nitrogen and other Nitro modules (e.g. react-native-mmkv) use — no consumer ProGuard rules needed. Verified with a minified release build: without the annotation R8 lists the class in usage.txt (removed); with it, the class and its no-arg constructor are kept in mapping.txt. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #406.
On Android,
react-native-compressor(Nitro) works in debug but fails to link in release builds —NitroModules.createHybridObject('Compressor')throws the linking error, so the module is unusable in production (reported on RN 0.85.3/ Expo).
Why this happens — R8 strips a JNI-instantiated class:
The
CompressorHybridObject implementation is created from C++/JNI by class-name string (generatedNitroCompressorOnLoad.cpp):