Skip to content

feat: compat with Nitro 3 #852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
KazariEX wants to merge 2 commits into
base: main
Choose a base branch
from
+11 −5
Draft

feat: compat with Nitro 3 #852

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
650ca8f
feat: compat with Nitro 3
KazariEX Jul 2, 2026
7b2e347
fix: choose different routes depended on nuxt version
KazariEX Jul 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/assets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ import { colors } from 'consola/utils'
import { defu } from 'defu'
import type { NitroConfig } from 'nitropack'
import { joinURL } from 'ufo'
import { join } from 'pathe'
import { join, basename } from 'pathe'

import { normalizeFontData } from 'fontless'
import type { NormalizeFontDataContext } from 'fontless'
Expand All @@ -29,8 +29,8 @@ export async function setupPublicAssetStrategy(options: ModuleOptions['assets']

// Register font proxy URL for development
async function devEventHandler(event: H3Event) {
const filename = event.path.slice(1)
const url = context.renderedFontURLs.get(event.path.slice(1))
const filename = basename(event.path)
const url = context.renderedFontURLs.get(filename)
Comment on lines +35 to +36

@coderabbitai coderabbitai Bot Jul 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

Does h3's event.path getter include the query string from the request URL?

💡 Result:

Yes, the event.path getter in h3 includes the query string from the request URL [1]. In H3, event.path provides the full path of the incoming request, including both the path and the query parameters (for example, "/test?test=123") [1]. However, please note that event.path is deprecated in H3 v2 [2]. It is recommended to use event.url.pathname and event.url.search instead to access the path and query string components separately [2].

Citations:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Inspect the relevant file and nearby context.
git ls-files src/assets.ts
wc -l src/assets.ts
cat -n src/assets.ts | sed -n '1,220p'

Repository: nuxt/fonts

Length of output: 6001

🏁 Script executed:

#!/bin/bash
set -euo pipefail

# Check for related path handling and any existing normalization helpers.
rg -n "basename\\(|event\\.path|renderedFontURLs|assetsBaseURL|pathname|search" src

Repository: nuxt/fonts

Length of output: 874

Strip query strings before deriving the font filename. event.path includes the search string in h3, so basename(event.path) will miss cached entries for requests like font.woff2?v=1 and 404. Use event.url.pathname (or strip event.url.search) here instead.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@src/assets.ts` around lines 32 - 33, The font lookup in the assets handler is
using event.path directly, so query strings from h3 requests can make
basename(...) miss cached entries and cause false 404s. Update the logic in the
assets.ts flow around the filename/url lookup to derive the name from
event.url.pathname, or otherwise strip event.url.search before calling basename,
so renderedFontURLs keys match requests like font.woff2?v=1.

if (!url) {
throw createError({ statusCode: 404 })
}
Expand All @@ -47,7 +47,7 @@ export async function setupPublicAssetStrategy(options: ModuleOptions['assets']
}

addDevServerHandler({
route: joinURL(nuxt.options.runtimeConfig.app.baseURL || nuxt.options.app.baseURL, context.assetsBaseURL),
route: joinURL(nuxt.options.runtimeConfig.app.baseURL || nuxt.options.app.baseURL, context.assetsBaseURL, '**'),

@KazariEX KazariEX Jul 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incompatible with Nitro 2 🧐

@zsilbi zsilbi Jul 28, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Number.parseInt(getNuxtVersion(nuxt)) >= 5 would help to decide which route to use.

I think we also need to update this to @nuxt/kit: ^4.3.0 to use middleware: true here for h3 v2

handler: eventHandler(devEventHandler),
})

Expand Down Expand Up @@ -89,6 +89,7 @@ export async function setupPublicAssetStrategy(options: ModuleOptions['assets']
dir: cacheDir,
maxAge: ONE_YEAR_IN_SECONDS,
baseURL: context.assetsBaseURL,
fallthrough: nuxt.options.dev,
}],
ignore: [`!${join(cacheDir, '**/*')}`],
prerender: {
Expand Down
Loading