Skip to content

chore: remove workaround for nwjs.app #1630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ayushmanchhabra wants to merge 3 commits into
base: main
Choose a base branch
from
+17 −20
Open

chore: remove workaround for nwjs.app #1630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
32f40bd
chore: remove workarouns
ayushmanchhabra Aug 11, 2026
0835cc7
chore: resolve format and lint errors
ayushmanchhabra Aug 11, 2026
e2c34dd
chore: resolve vulns
ayushmanchhabra Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 5 additions & 8 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,22 +9,19 @@ Since `v4.6.0`, we have switched to automated releases and this file does not ne

## [4.18.0](https://github.com/nwutils/nw-builder/compare/v4.17.13...v4.18.0) (2026-07-25)


### Features

* **bld:** add option to ignore files/folder during file globbing ([#1615](https://github.com/nwutils/nw-builder/issues/1615)) ([6a3eb87](https://github.com/nwutils/nw-builder/commit/6a3eb87a91f9d5361b598e9a6297844a6208a594))

- **bld:** add option to ignore files/folder during file globbing ([#1615](https://github.com/nwutils/nw-builder/issues/1615)) ([6a3eb87](https://github.com/nwutils/nw-builder/commit/6a3eb87a91f9d5361b598e9a6297844a6208a594))

### Bug Fixes

* **bld:** workaround for version mismatch in nwjs.app ([#1628](https://github.com/nwutils/nw-builder/issues/1628)) ([fdddcf0](https://github.com/nwutils/nw-builder/commit/fdddcf088b7b7626c98288b73d53682bbdf6273c)), closes [#1624](https://github.com/nwutils/nw-builder/issues/1624)

- **bld:** workaround for version mismatch in nwjs.app ([#1628](https://github.com/nwutils/nw-builder/issues/1628)) ([fdddcf0](https://github.com/nwutils/nw-builder/commit/fdddcf088b7b7626c98288b73d53682bbdf6273c)), closes [#1624](https://github.com/nwutils/nw-builder/issues/1624)

### Chores

* **ci:** run tests on {Linux, Mac, Windows} x {Intel, ARM} ([#1625](https://github.com/nwutils/nw-builder/issues/1625)) ([846ca3b](https://github.com/nwutils/nw-builder/commit/846ca3b2c6de0b1b690edc164f09aaed3412cfc3))
* **deps:** bump the gha group across 1 directory with 3 updates ([#1622](https://github.com/nwutils/nw-builder/issues/1622)) ([9d4ed4f](https://github.com/nwutils/nw-builder/commit/9d4ed4f50c3b2f7ff212ab3b670c3cd544314a13))
* **deps:** bump the npm group across 1 directory with 7 updates ([#1627](https://github.com/nwutils/nw-builder/issues/1627)) ([9a9cdd5](https://github.com/nwutils/nw-builder/commit/9a9cdd5c8b5085851bb78c11abc23881f3ec8899))
- **ci:** run tests on {Linux, Mac, Windows} x {Intel, ARM} ([#1625](https://github.com/nwutils/nw-builder/issues/1625)) ([846ca3b](https://github.com/nwutils/nw-builder/commit/846ca3b2c6de0b1b690edc164f09aaed3412cfc3))
- **deps:** bump the gha group across 1 directory with 3 updates ([#1622](https://github.com/nwutils/nw-builder/issues/1622)) ([9d4ed4f](https://github.com/nwutils/nw-builder/commit/9d4ed4f50c3b2f7ff212ab3b670c3cd544314a13))
- **deps:** bump the npm group across 1 directory with 7 updates ([#1627](https://github.com/nwutils/nw-builder/issues/1627)) ([9a9cdd5](https://github.com/nwutils/nw-builder/commit/9a9cdd5c8b5085851bb78c11abc23881f3ec8899))

## [4.17.13](https://github.com/nwutils/nw-builder/compare/v4.17.12...v4.17.13) (2026-07-02)

Expand Down
12 changes: 6 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/bld/osx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ export default async function setOsxConfig({
outApp,
"Contents/Frameworks/nwjs Framework.framework/Versions",
/* TODO: Version mismatch tracked in https://github.com/nwjs/nw.js/issues/8371 */
"Current",
chromiumVersion,
"Helpers",
);

Expand Down
2 changes: 1 addition & 1 deletion tests/specs/bld.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe.skip("bld test suite", async () => {
const nwOptions = {
srcDir: "tests/fixtures/app",
mode: "build",
version: "0.114.0",
version: "0.114.1",
flavor: "sdk",
platform: util.PLATFORM_KV[process.platform],
arch: util.ARCH_KV[process.arch],
Expand Down
8 changes: 4 additions & 4 deletions tests/specs/osx.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
"Frameworks",
"nwjs Framework.framework",
"Versions",
"Current",
chromiumVersion,
"Helpers",
"Demo Helper (Alerts).app",
);
Expand All @@ -41,7 +41,7 @@
"Frameworks",
"nwjs Framework.framework",
"Versions",
"Current",
chromiumVersion,
"Helpers",
"Demo Helper (GPU).app",
);
Expand All @@ -51,7 +51,7 @@
"Frameworks",
"nwjs Framework.framework",
"Versions",
"Current",
chromiumVersion,
"Helpers",
"Demo Helper (Renderer).app",
);
Expand All @@ -61,7 +61,7 @@
"Frameworks",
"nwjs Framework.framework",
"Versions",
"Current",
chromiumVersion,
"Helpers",
"Demo Helper.app",
);
Expand Down Expand Up @@ -101,7 +101,7 @@
expect(appPathExists).toEqual(true);

const helperAlertsPathExists = await util.fileExists(helperAlertsPath);
expect(helperAlertsPathExists).toEqual(true);

Check failure on line 104 in tests/specs/osx.test.js

View workflow job for this annotation

GitHub Actions / MacOS 26 ARM

tests/specs/osx.test.js > bld/setOsxConfig > renames the .app files correctly 

AssertionError: expected false to deeply equal true

- Expected
+ Received

- true
+ false

 ❯ tests/specs/osx.test.js:104:38

Check failure on line 104 in tests/specs/osx.test.js

View workflow job for this annotation

GitHub Actions / MacOS 26 Intel

tests/specs/osx.test.js > bld/setOsxConfig > renames the .app files correctly 

AssertionError: expected false to deeply equal true

- Expected
+ Received

- true
+ false

 ❯ tests/specs/osx.test.js:104:38

const helperGPUPathExists = await util.fileExists(helperGPUPath);
expect(helperGPUPathExists).toEqual(true);
Expand All @@ -127,7 +127,7 @@
);
const helperAlertsExePathExists =
await util.fileExists(helperAlertsExePath);
expect(helperAlertsExePathExists).toEqual(true);

Check failure on line 130 in tests/specs/osx.test.js

View workflow job for this annotation

GitHub Actions / MacOS 26 ARM

tests/specs/osx.test.js > bld/setOsxConfig > renames the executables correctly 

AssertionError: expected false to deeply equal true

- Expected
+ Received

- true
+ false

 ❯ tests/specs/osx.test.js:130:41

Check failure on line 130 in tests/specs/osx.test.js

View workflow job for this annotation

GitHub Actions / MacOS 26 Intel

tests/specs/osx.test.js > bld/setOsxConfig > renames the executables correctly 

AssertionError: expected false to deeply equal true

- Expected
+ Received

- true
+ false

 ❯ tests/specs/osx.test.js:130:41

const helperGPUExePath = path.join(
helperGPUPath,
Expand Down Expand Up @@ -168,7 +168,7 @@
const ContentsInfoPlistJson = parse(
await fs.promises.readFile(ContentsInfoPlistPath, "utf-8"),
);
expect(ContentsInfoPlistJson.LSApplicationCategoryType).toEqual(

Check failure on line 171 in tests/specs/osx.test.js

View workflow job for this annotation

GitHub Actions / MacOS 26 ARM

tests/specs/osx.test.js > bld/setOsxConfig > 

AssertionError: expected undefined to deeply equal 'public.app-category.utilities'

- Expected:
"public.app-category.utilities"

+ Received:
undefined

 ❯ tests/specs/osx.test.js:171:63

Check failure on line 171 in tests/specs/osx.test.js

View workflow job for this annotation

GitHub Actions / MacOS 26 Intel

tests/specs/osx.test.js > bld/setOsxConfig > 

AssertionError: expected undefined to deeply equal 'public.app-category.utilities'

- Expected:
"public.app-category.utilities"

+ Received:
undefined

 ❯ tests/specs/osx.test.js:171:63
"public.app-category.utilities",
);
expect(ContentsInfoPlistJson.CFBundleIdentifier).toEqual(
Expand Down
Loading