Require explicit acknowledgement for plaintext remote Brainstorm binds - #2041
Open
avzamelek wants to merge 1 commit into
Open
Require explicit acknowledgement for plaintext remote Brainstorm binds#2041avzamelek wants to merge 1 commit into
avzamelek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Who is submitting this PR? (required)
What problem are you trying to solve?
In a remote/containerized Brainstorm Companion session, I needed to bind the
server with
--host 0.0.0.0so that a browser outside the executionenvironment could access it.
The companion serves HTTP only and returns a URL containing
?key=<session-token>. This token is a bearer credential accepted by both theHTTP endpoints and WebSocket upgrade path. If a non-loopback listener is
exposed over an untrusted network without encrypted transport, an observer can
capture and replay the token to read companion screens and files or submit
WebSocket events that are persisted to
state/events.The previous launcher made a plaintext non-loopback bind easy to select without
requiring the operator to explicitly acknowledge that transport boundary.
What does this PR change?
--insecure-remote.pattern.
proxy or another trusted encrypted transport.
behavior.
Is this change appropriate for the core library?
Yes. This changes the shared Brainstorm Companion launch path and protects all
users who run the companion outside a loopback-only environment. It is not
project-, harness-, or vendor-specific.
What alternatives did you consider?
Adding TLS directly to the zero-dependency companion server would require
certificate and private-key configuration, as well as a broader deployment and
support model. Keeping loopback as the secure default and recommending SSH port
forwarding preserves the existing architecture. The explicit
--insecure-remoteescape hatch preserves deployments that already provide TLStermination or an equivalent trusted transport.
Does this PR contain multiple unrelated changes?
No. The launcher guard, remote-access documentation, and regression tests are
one cohesive security change: preventing accidental plaintext non-loopback
exposure of a bearer-authenticated companion.
Existing PRs
Environment tested
Validation run:
New harness support
Not applicable. This PR does not add or modify support for any harness.
Evaluation
--host 0.0.0.0.--insecure-remoteis explicitly supplied.Rigor
Human review