Repository navigation
fix: express peer dependencies as ranges, drop unused dependencies - #201
Draft
saberzero1 wants to merge 1 commit into
Draft
saberzero1 wants to merge 1 commit into
saberzero1 wants to merge 1 commit into
Conversation
peerDependencies were pinned narrowly while the matching dependency moved forward, forcing consumers onto --legacy-peer-deps (#198, #144). - obsidian was pinned to =1.8.7 as a peer while dependencies carried 1.12.3. It is never imported by lib/, so it moves to devDependencies and the peer is dropped; no-unsupported-api already reads the consumer's own obsidian.d.ts out of the TypeScript program. - @eslint/js and @eslint/json are plain runtime dependencies, not peers, and no longer appear in peerDependencies. - typescript is a runtime import in two rules, so it becomes a peer with an open-ended floor. An upper bound would only duplicate typescript-eslint's own ceiling and go stale the moment that widens. - typescript-eslint stays a peer at its dependency range, because the recommended config registers the @typescript-eslint namespace and a second copy is a hard "Cannot redefine plugin" failure. eslint, @types/eslint and @types/node were runtime dependencies despite being type-only or build-only, so they move to devDependencies. @eslint/core was imported by lib/index.ts without being declared at all. eslint-plugin-depend and @eslint/json are registered under shared plugin namespaces, so their exact pins guaranteed a duplicate copy and the same "Cannot redefine plugin" error for any consumer using those plugins directly. Both now use a caret range. eslint-plugin-security and eslint-plugin-json-schema-validator were declared but referenced nowhere in lib/, tests/ or the built output; the former also shadowed the copy @microsoft/eslint-plugin-sdl resolves for itself. README now documents the obsidian devDependency, which the plugin previously supplied to consumers by accident through dependency hoisting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
peerDependencies were pinned narrowly while the matching dependency moved forward, forcing consumers onto --legacy-peer-deps (#198, #144).
eslint, @types/eslint and @types/node were runtime dependencies despite being type-only or build-only, so they move to devDependencies. @eslint/core was imported by lib/index.ts without being declared at all.
eslint-plugin-depend and @eslint/json are registered under shared plugin namespaces, so their exact pins guaranteed a duplicate copy and the same "Cannot redefine plugin" error for any consumer using those plugins directly. Both now use a caret range.
eslint-plugin-security and eslint-plugin-json-schema-validator were declared but referenced nowhere in lib/, tests/ or the built output; the former also shadowed the copy @microsoft/eslint-plugin-sdl resolves for itself.
README now documents the obsidian devDependency, which the plugin previously supplied to consumers by accident through dependency hoisting.