Skip to content

stdint and zmq packages#33

Open
mryau wants to merge 13 commits intoocaml-cross:masterfrom
mryau:master
Open

stdint and zmq packages#33
mryau wants to merge 13 commits intoocaml-cross:masterfrom
mryau:master

Conversation

@mryau
Copy link
Copy Markdown

@mryau mryau commented May 26, 2017

No description provided.

Comment thread packages/stdint-android.0.3.0/opam Outdated
build-doc: [ "ocaml" "setup.ml" "-doc" ]
depends: [
"ocaml-android"
"base-bytes"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implied in ocaml-android

Comment thread packages/stdint-android.0.3.0/opam Outdated
depends: [
"ocaml-android"
"base-bytes"
"ocamlfind" {>= "1.5"}
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implied in ocaml-android

Comment thread packages/zmq-android.4.0-8/findlib Outdated
@@ -0,0 +1 @@
zmq
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed as opam does not know about -toolchain

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello,

without such findlib files for zmq-android and stdint, ocamlfind can't find this packages when I compile my code.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That doesn't make any sense, ocamlfind does not use these "findlib" files. Are you sure there was no other difference? Can you check one more time please?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no findlib files in opam-repository anymore. ocaml/opam-repository#9328

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I remove them too -- on clear installation I don't seen problems without findlib files.

Comment thread packages/stdint-android.0.3.0/findlib Outdated
@@ -0,0 +1 @@
stdint
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not needed as opam does not know about -toolchain

Comment thread packages/zmq-android.4.0-8/opam Outdated
depends: [
"ocaml-android"
"conf-zmq-android"
"ocamlfind"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implied in ocaml-android

Comment thread packages/zmq-android.4.0-8/opam Outdated
"ocaml-android"
"conf-zmq-android"
"ocamlfind"
"base-unix"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implied in ocaml-android

"ocamlbuild" {build}
]
conflicts: [
"ocaml-zmq"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a reason for this conflict

Copy link
Copy Markdown
Author

@mryau mryau May 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm steal this opam file from author of package, and just modified related part's. This line written by author of zmq.

@@ -0,0 +1,3 @@
Virtual package relying on zmq library installation.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not use virtual packages for native dependencies in cross-toolchains

]
depends: [
"ocaml-android"
"conf-zmq-android"
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of this dependency, you should add a depext for the zmq package in MXE

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is MXE means http://mxe.cc/ ?
I don't use android-ndk -- I'm sit on yocto/bitbake with plain gcc cross-compiler suite, so I can't use it.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, MXE is not relevant, forget this part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants