removed text-relocations from android32 and added android64#42
Open
markghayden wants to merge 7 commits intoocaml-cross:masterfrom
Open
removed text-relocations from android32 and added android64#42markghayden wants to merge 7 commits intoocaml-cross:masterfrom
markghayden wants to merge 7 commits intoocaml-cross:masterfrom
Conversation
added 7 commits
November 14, 2018 15:50
Added android64 Fixes for some out-of-date urls
|
Hi @whitequark, With these changes i was able to install ocaml-android for arm64 android. It will be helpful if these changes are merged. |
Member
|
@ossdev07 This is a large and complex patch. I have a limited amount of time to spend on OSS maintenance and I will not be able to review it any time soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes to arm.S are based on arm64 version, but are not well optimized. On 32-bit arm an extra register is needed. For simplicity we use push/pop, which has poor performance. One of the core ocaml people will want to improve on this.