Skip to content

test(definition): cover requests on non-Merlin documents #2124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rgrinberg wants to merge 1 commit into
base: master
Choose a base branch
from
+31 −0
Open

test(definition): cover requests on non-Merlin documents #2124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions ocaml-lsp-server/test/e2e-new/definition.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,3 +84,34 @@ let () =
]
|}]
;;

let%expect_test "definition on a non-Merlin document returns null" =
(Test.run_initialized
@@ fun client ->
let uri = DocumentUri.of_path "test.t" in
let text =
TextDocumentItem.create
~uri
~languageId:(LanguageKind.Other "cram")
~version:0
~text:" $ echo hello\n"
in
let* () =
Client.notification
client
(TextDocumentDidOpen (DidOpenTextDocumentParams.create ~textDocument:text))
in
let textDocument = TextDocumentIdentifier.create ~uri in
let* response =
Client.request
client
(TextDocumentDefinition
(DefinitionParams.create
~textDocument
~position:(Position.create ~line:0 ~character:8)
()))
in
print_locations response;
Test.shutdown_client client);
[%expect {| [] |}]
;;
Loading