Skip to content

test(hover): cover module, signature and pattern items #2126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rgrinberg merged 1 commit into from
Aug 8, 2026
Merged

test(hover): cover module, signature and pattern items #2126

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 66 additions & 0 deletions ocaml-lsp-server/test/e2e-new/hover.ml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,3 +379,69 @@ let use = Exn 1
}
|}]
;;

let%expect_test "hover on module, class and signature items" =
let source =
{ocaml|
module type S = sig
module N : sig end
open S
end
module M : S = struct end
class type ct = object method m : int end
type point = { px : int; py : int }
let f ({ px; py } as p : point) = px + py
|ocaml}
in
Hover_helpers.test_hover
source
[ Position.create ~line:2 ~character:9
; Position.create ~line:3 ~character:7
; Position.create ~line:5 ~character:7
; Position.create ~line:6 ~character:11
; Position.create ~line:8 ~character:9
; Position.create ~line:8 ~character:11
];
[%expect
{|
{
"contents": { "kind": "plaintext", "value": "sig end" },
"range": {
"end": { "character": 10, "line": 2 },
"start": { "character": 9, "line": 2 }
}
}
{
"contents": {
"kind": "plaintext",
"value": "sig\n module N : sig end\nend"
},
"range": {
"end": { "character": 3, "line": 4 },
"start": { "character": 16, "line": 1 }
}
}
{
"contents": { "kind": "plaintext", "value": "sig end" },
"range": {
"end": { "character": 8, "line": 5 },
"start": { "character": 7, "line": 5 }
}
}
no hover response
{
"contents": { "kind": "plaintext", "value": "int" },
"range": {
"end": { "character": 11, "line": 8 },
"start": { "character": 9, "line": 8 }
}
}
{
"contents": { "kind": "plaintext", "value": "int" },
"range": {
"end": { "character": 11, "line": 8 },
"start": { "character": 9, "line": 8 }
}
}
|}]
;;
Loading