fix(ocamlformat-rpc): degrade gracefully when the process dies at startup - #2133
Open
rgrinberg wants to merge 1 commit into
Open
fix(ocamlformat-rpc): degrade gracefully when the process dies at startup#2133rgrinberg wants to merge 1 commit into
rgrinberg wants to merge 1 commit into
Conversation
rgrinberg
force-pushed
the
push-sosupvlrsvsp
branch
from
August 7, 2026 22:40
fed23b2 to
e0ebb49
Compare
…rtup Signed-off-by: Rudi Grinberg <me@rgrinberg.com>
rgrinberg
force-pushed
the
push-sosupvlrsvsp
branch
from
August 7, 2026 23:01
e0ebb49 to
5a4f150
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An
ocamlformat-rpcprocess that dies or produces garbage during startupversion negotiation used to raise an uncaught exception ("fd closed
unflushed") that failed the hover request with an internal error.
Wrap
Process.createinFiber.collect_errorsand report the failure as anerror
LogMessage, degrading to unformatted hover types instead of failingthe request. Fixes the reproduction in #2132.