[new release] lsp (3 packages) (1.25.0) - #29118
Merged
Merged
Conversation
CHANGES: ## Features - Make `code-lens` for nested let bindings configurable (ocaml/ocaml-lsp#1567) - Add support for `.mlx` files, including formatting via `ocamlformat-mlx` and most OCaml LSP features (diagnostics, code actions, hover, etc.) (ocaml/ocaml-lsp#1528) - Add `typeExpression` custom request (ocaml/ocaml-lsp#1576) - Add `locate` custom request (ocaml/ocaml-lsp#1576) - Add `phrase` custom request (ocaml/ocaml-lsp#1576) ## Fixes - Improve precision of collected metrics timestamps. (ocaml/ocaml-lsp#1565) - Fallback on `.merlin` configuration if no `dune-project` file is found and if `dot-merlin-reader` is installed. (ocaml/ocaml-lsp#1563, fixes ocaml/ocaml-lsp#1522)
Contributor
Author
|
Sorry for that. I fixed it upstream too. |
jmid
approved these changes
Dec 20, 2025
jmid
left a comment
jmid
left a comment
Member
There was a problem hiding this comment.
Thanks, this now LGTM!
CI is down to a single opam-2.0 failure.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LSP protocol implementation in OCaml
CHANGES:
Features
code-lensfor nested let bindings configurable (Makecode-lensfor toplevel let binding configurable ocaml-lsp#1567).mlxfiles, including formatting viaocamlformat-mlxand most OCaml LSP features (diagnostics, code actions, hover, etc.) (Add ocamlformat-mlx and most ocaml features for .mlx ocaml-lsp#1528)typeExpressioncustom request (Add some missing custom request ocaml-lsp#1576)locatecustom request (Add some missing custom request ocaml-lsp#1576)phrasecustom request (Add some missing custom request ocaml-lsp#1576)Fixes
view-metricsocaml-lsp#1565).merlinconfiguration if nodune-projectfile is found and ifdot-merlin-readeris installed. (More natural fallback on .merlin files when no dune-project is found. ocaml-lsp#1563, fixes Why isn't --fallback-read-dot-merlin the default? ocaml-lsp#1522)